Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of deprecated gates from qiskit.extensions #4366

Merged

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Apr 30, 2020

The monkeypatching PR didn't allow to import the deprecated gate names (such as Cu1Gate) to be imported from qiskit.extensions. This is fixed and a test added.

Summary

Fixes #4365.

Details and comments

The monkeypatching PR didn't allow to import the deprecated gate names (such as Cu1Gate) to be imported from qiskit.extensions. This is fixed and a test added.

The monkeypatching PR didn't allow to import the deprecated gate names (such as Cu1Gate) to be imported from qiskit.extensions. This is fixed and a test added.
@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Apr 30, 2020
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mtreinish mtreinish added automerge Changelog: Bugfix Include in the "Fixed" section of the changelog labels Apr 30, 2020
@mergify mergify bot merged commit 61b5e24 into Qiskit:master Apr 30, 2020
mergify bot pushed a commit that referenced this pull request Apr 30, 2020
The monkeypatching PR didn't allow to import the deprecated gate names (such as Cu1Gate) to be imported from qiskit.extensions. This is fixed and a test added.

(cherry picked from commit 61b5e24)
mergify bot added a commit that referenced this pull request Apr 30, 2020
The monkeypatching PR didn't allow to import the deprecated gate names (such as Cu1Gate) to be imported from qiskit.extensions. This is fixed and a test added.

(cherry picked from commit 61b5e24)

Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
@Cryoris Cryoris deleted the allow-deprecated-import-from-extensions branch May 8, 2020 12:29
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this pull request Aug 5, 2020
The monkeypatching PR didn't allow to import the deprecated gate names (such as Cu1Gate) to be imported from qiskit.extensions. This is fixed and a test added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old classes are not accessible via qiskit.extensions
2 participants