Fix disassemble of isometry and added test_disassemble_isometry #4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enavarro51
requested review from
1ucian0,
ajavadia,
kdk,
lcapelluto,
mtreinish and
taalexander
as code owners
mtreinish
approved these changes
May 18, 2020
There was a problem hiding this comment.
This LGTM, the underlying issue is a bit weird qobj is normally only used for passing circuits to a backend and no backend supports the isometry instruction. But I guess if you're using it as a more general serialization format for circuits (it wouldn't be my first choice for that but it conceivable) then I could see this coming up.
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…it#4402) * Treat call to isometry in disassemble as special case * Added test_disassemble_isometry Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mtreinish
added
the
Changelog: Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4381
Details and comments
Fixed failure of disassemble of circuit with an isometry gate. Added test_disassemble_isometry.