Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SetPhase instruction to pulse #4540

Merged
merged 19 commits into from
Jun 12, 2020
Merged

Add SetPhase instruction to pulse #4540

merged 19 commits into from
Jun 12, 2020

Conversation

SooluThomas
Copy link
Member

@SooluThomas SooluThomas commented Jun 3, 2020 •
edited
Loading

Summary

This PR adds SetPhase instruction to pulse.

TO-DO

  • Reno

lcapelluto
lcapelluto suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@lcapelluto lcapelluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @SooluThomas ! Minor scattered comments

qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
qiskit/visualization/pulse/matplotlib.py Show resolved Hide resolved
test/python/pulse/test_schedule.py Outdated Show resolved Hide resolved
@taalexander taalexander mentioned this pull request Jun 3, 2020
Merged
3 tasks
lcapelluto
lcapelluto reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@lcapelluto lcapelluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks, now! 😊

qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
test/python/pulse/test_schedule.py Outdated Show resolved Hide resolved
qiskit/visualization/pulse/matplotlib.py Show resolved Hide resolved
@SooluThomas SooluThomas requested a review from lcapelluto June 4, 2020 19:14
@lcapelluto lcapelluto self-assigned this Jun 8, 2020
lcapelluto
lcapelluto reviewed Jun 9, 2020
View reviewed changes
Copy link
Contributor

@lcapelluto lcapelluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Caught one last thing: I think the type of phase in SetPhase.__init__ should be float rather than complex

qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
qiskit/visualization/pulse/matplotlib.py Show resolved Hide resolved
@SooluThomas
Copy link
Member Author

Docs build failing -- the fix is in #4556

taalexander
taalexander requested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@taalexander taalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments.

qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
qiskit/pulse/instructions/phase.py Outdated Show resolved Hide resolved
@lcapelluto lcapelluto added automerge Changelog: API Change Include in the "Changed" section of the changelog Changelog: New Feature Include in the "Added" section of the changelog and removed Changelog: API Change Include in the "Changed" section of the changelog labels Jun 12, 2020
@mergify mergify bot merged commit e2bdb2d into Qiskit:master Jun 12, 2020
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this pull request Aug 5, 2020
@SooluThomas @mergify
Add SetPhase instruction to pulse (Qiskit#4540)
64a73a3 
* Add SetPhase instruction

* visualization

* Update qobj schema

* Review suggestions

* typo

* Review comments

* change framechange to phase in mpl draw

* typo

* add reno

* Separate set phase and shift phase in visualization

* lint

* lint

* review comments

* review comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@1ucian0 1ucian0 added the mod: pulse Related to the Pulse module label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcapelluto lcapelluto lcapelluto approved these changes

@taalexander taalexander taalexander approved these changes

@DanPuzzuoli DanPuzzuoli Awaiting requested review from DanPuzzuoli

@eggerdj eggerdj Awaiting requested review from eggerdj

@maddy-tod maddy-tod Awaiting requested review from maddy-tod

@nkanazawa1989 nkanazawa1989 Awaiting requested review from nkanazawa1989

@nonhermitian nonhermitian Awaiting requested review from nonhermitian

Assignees

@lcapelluto lcapelluto

Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: pulse Related to the Pulse module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SooluThomas @taalexander @lcapelluto @1ucian0