disallow specifying controlled gate with zero controls. #4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdk
previously approved these changes
Jun 18, 2020
Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
kdk
previously approved these changes
Jun 18, 2020
kdk
added
automerge
Changelog: Bugfix
kdk
reviewed
Jun 19, 2020
releasenotes/notes/disallow_num_ctrl_qubits_zero-eb102aa087f30250.yaml
Outdated
Show resolved
Hide resolved
…250.yaml Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
kdk
approved these changes
Jun 25, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* disallow num_ctrl_qubits=0. * update mcxgate * doc typo in qiskit/circuit/controlledgate.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * Update releasenotes/notes/disallow_num_ctrl_qubits_zero-eb102aa087f30250.yaml Co-authored-by: Kevin Krsulich <kevin@krsulich.net> Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com> Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when calling a gate's
controlmethod it was possible to specify 0 controls in which case the original gate is returned.Fixes #4576.
Details and comments
This pr requires that the number of control qubits be an integer in the range [1, num_qubits-1].