Fix cnot method on QuantumCircuit #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cnot method for QuantumCircuit was broken when using positional arguments that weren't named. This is because it was upassing in the kwargs which aren't used from deprecated_arguments to the cx method. The kwargs are only used as a placeholder for passing in args by name from the old deprecated name and the conversion is handled by the decorator. This commit fixes this oversight so that QuantumCircuit.cnot works as expected. Fixes Qiskit#4708
ajavadia
previously approved these changes
Jul 15, 2020
|
can you add a test? |
Sure, done in: 0b0c5ab |
Cryoris
approved these changes
Jul 15, 2020
|
Thank you! |
mtreinish
added
the
Changelog: Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The cnot method for QuantumCircuit was broken when using positional
arguments that weren't named. This is because it was upassing in the
kwargs which aren't used from deprecated_arguments to the cx method.
The kwargs are only used as a placeholder for passing in args by name
from the old deprecated name and the conversion is handled by the
decorator. This commit fixes this oversight so that QuantumCircuit.cnot
works as expected.
Details and comments
Fixes #4708