Circuit.mcry with mode 'basic' uses MCXVChain #4787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdk
previously approved these changes
Sep 22, 2020
|
Is there a test case that should've caught this? If not, can you add one? |
kdk
approved these changes
Sep 29, 2020
kdk
added
Changelog: Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4786.
Details and comments
The default mode of
mcxhas been changed frombasic/v-chain(basic was the old name, v-chain is the new name) tonoancilla. Themcrymethod was relying on the default mode beingbasicif sufficient ancilla qubits are provided, which has been fixed accordingly.