Fixes #4774. Schedule inserts needed for long sequences. #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehchen
requested review from
DanPuzzuoli,
eggerdj,
nkanazawa1989 and
a team
as code owners
taalexander
requested changes
Jul 23, 2020
qiskit/pulse/transforms.py
Outdated
| @@ -110,13 +110,13 @@ def get_max_calibration_duration(): | |||
| if time > align_time: | |||
| warnings.warn("You provided an align_time which is scheduling an acquire " | |||
| "sooner than it was scheduled for in the original Schedule.") | |||
| new_schedule |= inst << align_time | |||
| new_schedule(align_time, inst, inplace=True) | |||
There was a problem hiding this comment.
I believe we're missing the .insert here.
taalexander
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pulse transforms need proper inserts to schedule so that longer sequences don't fail.
Details and comments
This addresses bug #4774, so no release note or docstrings were modified. No tests were included. I believe tests included in the PR for #4755 should have caught this error. I ran both tox -py38 and tox -elint successfully.Thanks to @nkanazawa1989 and @taalexander for identification and proposing the solution to the problem.Changelog: Bugfix Fixed