Remove autoscale view call from plot_state_hinton #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the use of matplotlib's autoscale_view() [1] from the plot state hinton visualization. This function is truncating the plot if there are axis that are empty. This is not really necessary for the hinton function anyway since we have fixed limits on the plots as we add the ticks based on the shape of the input matrix. However it was being used to handle boxes on edges of the graph (ie when the top row or right most edge had a box) that wouldn't be properly centered. This commit worksaround that by padding both sides of the tick list to ensure the data is always centered. Fixes Qiskit#4249 [1] https://matplotlib.org/api/_as_gen/matplotlib.axes.Axes.autoscale_view.html
mtreinish
requested review from
maddy-tod,
nonhermitian and
a team
as code owners
1ucian0
previously requested changes
Aug 1, 2020
There was a problem hiding this comment.
I might be missing something. Here is the output on the branch mtreinish:fix-hinton:
from qiskit import QuantumCircuit, BasicAer, execute, visualization
qc = QuantumCircuit(2)
qc.h(0)
qc.cx(0,1)
qc.z(1)
backend = BasicAer.get_backend('statevector_simulator')
job = execute(qc, backend=backend)
sv = job.result().get_statevector(qc)
visualization.plot_state_hinton(sv)
In master, it looks fine:
|
Ugh, yeah it looks like everything is off by one now, in that case. I only tested the bug case and it worked fine for that, but clearly this needs more adjustment |
|
With @chriseclectic fix on top of my branch this works fine with the example before:
so this should be good to go now. |
chriseclectic
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit removes the use of matplotlib's autoscale_view() [1] from
the plot state hinton visualization. This function is truncating the
plot if there are axis that are empty. This is not really necessary for
the hinton function anyway since we have fixed limits on the plots as we
add the ticks based on the shape of the input matrix. However it was
being used to handle boxes on edges of the graph (ie when the top row or
right most edge had a box) that wouldn't be properly centered. This
commit worksaround that by padding both sides of the tick list to ensure
the data is always centered.
Details and comments
[1] https://matplotlib.org/api/_as_gen/matplotlib.axes.Axes.autoscale_view.html
Co-authored-by: Christopher J. Wood cjwood@us.ibm.com
Fixes #4249