Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PhaseGate.control(n) to return MCPhaseGate #4994

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Update PhaseGate.control(n) to return MCPhaseGate #4994

merged 3 commits into from
Aug 31, 2020

Conversation

kdk
Copy link
Member

@kdk kdk commented Aug 28, 2020

Summary

Also adds a release note for #4989 .

Details and comments

@kdk kdk added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Aug 28, 2020
@kdk kdk requested a review from a team as a code owner August 28, 2020 20:02
@kdk kdk force-pushed the multi-controlled-phase-gate-to-MCPhaseGate branch from aedda0e to 00b0d9d Compare August 28, 2020 20:04
Cryoris
Cryoris approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update!

@kdk kdk merged commit 81e73da into Qiskit:master Aug 31, 2020
mergify bot pushed a commit that referenced this pull request Aug 31, 2020
@kdk
Update PhaseGate.control(n) to return MCPhaseGate (#4994)
084d4f4 
* Fix PhaseGate.control to return an MCPhaseGate if multiple controls.

* Update test/python/circuit/test_controlled_gate.py

Co-authored-by: Julien Gacon <gaconju@gmail.com>
(cherry picked from commit 81e73da)
@mergify mergify bot mentioned this pull request Aug 31, 2020
Merged
kdk added a commit that referenced this pull request Aug 31, 2020
@mergify @kdk
Update PhaseGate.control(n) to return MCPhaseGate (#4994) (#5003)
6bae074 
* Fix PhaseGate.control to return an MCPhaseGate if multiple controls.

* Update test/python/circuit/test_controlled_gate.py

Co-authored-by: Julien Gacon <gaconju@gmail.com>
(cherry picked from commit 81e73da)

Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdk @Cryoris