Inverse of MCX gates to include ancillae #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdk
added
stable backport potential
|
It looks like this introduces some import cycles. My guess is we'll probably have to revisit what I did in: #4450 |
kdk
force-pushed
the
4953-Inverse-of-MCX-gates-generated-without-qubits-for-ancillae
branch
from
56e2ce9 to
071f71c
Compare
…t-qubits-for-ancillae
Cryoris
approved these changes
Sep 4, 2020
mtreinish
approved these changes
Sep 4, 2020
…t-qubits-for-ancillae
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2020
* SXGate().inverse() to return SXdgGate() and vice versa. * Instruction.inverse to no longer return modified copy of input gate. * Fix C3XGate.inverse to negate angle if non-zero. * MCXGate.inverse to return gate of same mode as original gate. Co-authored-by: Julien Gacon <jules.gacon@googlemail.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 70fc3f8)
kdk
added a commit
that referenced
this pull request
Sep 4, 2020
* SXGate().inverse() to return SXdgGate() and vice versa. * Instruction.inverse to no longer return modified copy of input gate. * Fix C3XGate.inverse to negate angle if non-zero. * MCXGate.inverse to return gate of same mode as original gate. Co-authored-by: Julien Gacon <jules.gacon@googlemail.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 70fc3f8) Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #4953 by adding
inversemethods to theMCXGatemodes which return gates of the same mode.Details and comments
Also, fixes some small related bugs that came up during testing:
SXGate().inverse()to returnSXdgGate()and vice versa.Instruction.inverseto no longer return modified copy of input gate.This is necessary for gates which do not have a defined
inversemethod and are not self-adjoint (e.g. DCX, iSwap), because the returned gate would have an updateddefinition, but still incorrectly retain properties of the original gate (namelyto_matrix).C3XGate.inverseto negate angle if non-zero.