-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate QuantumCircuit.u1/2/3 #5083
Conversation
Please keep a consistency with pulse builder module. |
The reason U1/U2/U3 existed was to have gates corresponding to 0-pulse, 1-pulse, and 2-pulse single-qubit gates. So you have some sense of the cost associated with your circuit. Now we can do this explicitly with Phase, sqrt(X) and U. So the replacements are:
Can you make sure to include these decompositions so people know how to transition while keeping the pulse numbers as they were? |
Co-authored-by: Ali Javadi-Abhari <ajavadia@users.noreply.github.com>
While re-reviewing Qiskit#5083 to find the source of a performance regression across the board on that commit I noticed that an empty file test.py was accidently committed to the root of the repo. This commit fixes that oversight and removes the file.
While re-reviewing #5083 to find the source of a performance regression across the board on that commit I noticed that an empty file test.py was accidently committed to the root of the repo. This commit fixes that oversight and removes the file.
This commit reverts a change made during Qiskit#5083 to use aqua from master for the tutorials job. This was done to workaround an aqua bug with a non-u1/u2/u3 basis that was occuring with the 0.7.x release of aqua. We typically use the released versions of the libraries in these jobs to catch potentially breaking changes for the biggest users of the terra api (the other qiskit elements). This restores this coverage by switching back to using the aqua release for the job.
This commit reverts a change made during #5083 to use aqua from master for the tutorials job. This was done to workaround an aqua bug with a non-u1/u2/u3 basis that was occuring with the 0.7.x release of aqua. We typically use the released versions of the libraries in these jobs to catch potentially breaking changes for the biggest users of the terra api (the other qiskit elements). This restores this coverage by switching back to using the aqua release for the job.
This commit reverts a change made during #5083 to use aqua from master for the tutorials job. This was done to workaround an aqua bug with a non-u1/u2/u3 basis that was occuring with the 0.7.x release of aqua. We typically use the released versions of the libraries in these jobs to catch potentially breaking changes for the biggest users of the terra api (the other qiskit elements). This restores this coverage by switching back to using the aqua release for the job. (cherry picked from commit cac869d)
While re-reviewing #5083 to find the source of a performance regression across the board on that commit I noticed that an empty file test.py was accidently committed to the root of the repo. This commit fixes that oversight and removes the file. (cherry picked from commit 95ccac9) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
This commit reverts a change made during #5083 to use aqua from master for the tutorials job. This was done to workaround an aqua bug with a non-u1/u2/u3 basis that was occuring with the 0.7.x release of aqua. We typically use the released versions of the libraries in these jobs to catch potentially breaking changes for the biggest users of the terra api (the other qiskit elements). This restores this coverage by switching back to using the aqua release for the job. (cherry picked from commit cac869d) Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
Continues on #4106.
Deprecate the methods
u1
,u2
andu3
of the circuit class. These gates are specific to the IBM hardware and are more commonly known as U-gate, instead of U3, and Phase-gate, instead of U1. The U2 gate has no standard equivalent but is easily created as special case of the U-gate. See below for a list of equivalences.While the circuit methods are being deprecated the gate objects remain such that it is still possible to transpile down to U1/U2/U3 and retrieve old jobs that use these gates.
Details and comments
Equivalences of the circuit methods:
WIP because the tests still use the methods and are still being updated.