transpile a list of circuits with a single element should return a list with a single element #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdk
approved these changes
Nov 12, 2020
mtreinish
pushed a commit
to Qiskit/qiskit-aer
that referenced
this pull request
Nov 16, 2020
In Qiskit/qiskit#5298 a bug was fixed to ensure that a singe entry list passed to `transpile()` would always return a list instead of just a circuit object. However, in the aer tests there were a couple of places that were building a list assuming transpile would return a bare circuit object. When the terra fix merged changing the return type the tests started to fail because the input to the `assemble()` function was now a list of a list of circuits instead of the intend list of circuits. This commit fixes this issue so it works with the corrected terra behavior.
1ucian0
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Dec 10, 2020
Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com> (cherry picked from commit 5be00b6)
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Dec 11, 2020
In Qiskit/qiskit#5298 a bug was fixed to ensure that a singe entry list passed to `transpile()` would always return a list instead of just a circuit object. However, in the aer tests there were a couple of places that were building a list assuming transpile would return a bare circuit object. When the terra fix merged changing the return type the tests started to fail because the input to the `assemble()` function was now a list of a list of circuits instead of the intend list of circuits. This commit fixes this issue so it works with the corrected terra behavior.
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Dec 11, 2020
In Qiskit/qiskit#5298 a bug was fixed to ensure that a singe entry list passed to `transpile()` would always return a list instead of just a circuit object. However, in the aer tests there were a couple of places that were building a list assuming transpile would return a bare circuit object. When the terra fix merged changing the return type the tests started to fail because the input to the `assemble()` function was now a list of a list of circuits instead of the intend list of circuits. This commit fixes this issue so it works with the corrected terra behavior.
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
In Qiskit/qiskit#5298 a bug was fixed to ensure that a singe entry list passed to `transpile()` would always return a list instead of just a circuit object. However, in the aer tests there were a couple of places that were building a list assuming transpile would return a bare circuit object. When the terra fix merged changing the return type the tests started to fail because the input to the `assemble()` function was now a list of a list of circuits instead of the intend list of circuits. This commit fixes this issue so it works with the corrected terra behavior.
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
In Qiskit/qiskit#5298 a bug was fixed to ensure that a singe entry list passed to `transpile()` would always return a list instead of just a circuit object. However, in the aer tests there were a couple of places that were building a list assuming transpile would return a bare circuit object. When the terra fix merged changing the return type the tests started to fail because the input to the `assemble()` function was now a list of a list of circuits instead of the intend list of circuits. This commit fixes this issue so it works with the corrected terra behavior.
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Apr 4, 2022
This commit fixes the return type when calling schedule() with a list of a single entry. Previously this would return a single Schedule object instead of the expected list return. A similar issue was already fixed in transpile() in Qiskit#5298 but schedule still had the incorrect behavior.
mergify bot
added a commit
that referenced
this pull request
Apr 4, 2022
This commit fixes the return type when calling schedule() with a list of a single entry. Previously this would return a single Schedule object instead of the expected list return. A similar issue was already fixed in transpile() in #5298 but schedule still had the incorrect behavior. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
This commit fixes the return type when calling schedule() with a list of a single entry. Previously this would return a single Schedule object instead of the expected list return. A similar issue was already fixed in transpile() in #5298 but schedule still had the incorrect behavior. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 6192bfd)
mergify bot
added a commit
that referenced
this pull request
Apr 5, 2022
This commit fixes the return type when calling schedule() with a list of a single entry. Previously this would return a single Schedule object instead of the expected list return. A similar issue was already fixed in transpile() in #5298 but schedule still had the incorrect behavior. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 6192bfd) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5260
When
transpileis called with a list, it should return a list, independently of the length of the list.