Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated DAGCircuit.qubits() and .clbits() methods. #5433

Merged
merged 5 commits into from
Dec 3, 2020

Conversation

kdk
Copy link
Member

@kdk kdk commented Nov 24, 2020

Summary

Deprecated in #4535 .

Details and comments

@kdk kdk requested a review from a team as a code owner November 24, 2020 23:29
@kdk kdk added the Changelog: Removal Include in the Removed section of the changelog label Nov 24, 2020
mtreinish
mtreinish previously approved these changes Nov 30, 2020
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments in the release notes, but something we can always fix at release time.

@kdk kdk force-pushed the dagcircuit-remove-deprecated-bit-methods branch from e73f0df to 07e25b5 Compare December 1, 2020 15:35
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the release note

@mergify mergify bot merged commit 19b6322 into Qiskit:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants