Use actual gate name in backend monitor #5546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyu00
added
Changelog: Bugfix
There was a PR doing this a while ago, but it didn't deprecate it first. The concern around doing this though is nothing in the widgets is ibmq specific necessarily (except for maybe the queue position pieces) and it should be possible to have them written in a generic way so that any backend could work with it. Ideally all providers would get this for free. (I realize it doesn't work this way today, but it could work like that in the future). |
taalexander
requested changes
Jan 4, 2021
taalexander
requested changes
Jan 5, 2021
Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com>
Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com>
taalexander
approved these changes
Jan 6, 2021
mtreinish
pushed a commit
that referenced
this pull request
Jan 7, 2021
* don't hard code gates * fix lint * add release note * match old format * fix instruction duration test * check gate name in title * Update qiskit/tools/jupyter/backend_monitor.py Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com> * Update qiskit/tools/monitor/overview.py Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com> * fix title * use props.gate_error * remove unused code Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit cf7433a) # Conflicts: # test/python/transpiler/test_instruction_durations.py
mergify bot
added a commit
that referenced
this pull request
Jan 7, 2021
* Use actual gate name in backend monitor (#5546) * don't hard code gates * fix lint * add release note * match old format * fix instruction duration test * check gate name in title * Update qiskit/tools/jupyter/backend_monitor.py Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com> * Update qiskit/tools/monitor/overview.py Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com> * fix title * use props.gate_error * remove unused code Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit cf7433a) # Conflicts: # test/python/transpiler/test_instruction_durations.py * Fix merge conflict Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new basis gate change broke backend monitor as it has the old gates hard coded. This PR fixes that by using the actual gate names returned in backend properties.
Also closes #5008.
Details and comments
Given we already have a backend widget in
qiskit-ibmq-provider, and the backend monitor here only acceptsIBMQBackendandFakeBackend, it seems we can just remove it from terra or invoke the one in ibmq.