Fix global phase handling in circuit.repeat #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
the
Changelog: Bugfix
This was referenced Jan 6, 2021
ewinston
approved these changes
Jan 6, 2021
mtreinish
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2021
* global phase should not be propagated in repeat * add reno (cherry picked from commit 7e40ed1)
kdk
pushed a commit
that referenced
this pull request
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5586.
Details and comments
Fix the global phase of the output of
circuit.repeat. If a circuit with globalphase is appended to another circuit, the global phase is currently not propagated.
The simulators rely on this, since the phase otherwise gets applied multiple times.
This sets the global phase of
circuit.repeatto 0 instead of multiplying the existingphase times the number of repetitions.