Update interpretation of meas_map in Qiskit #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SooluThomas
requested review from
DanPuzzuoli,
eggerdj,
lcapelluto,
nkanazawa1989,
taalexander and
a team
as code owners
SooluThomas
changed the title
lcapelluto
suggested changes
Mar 5, 2021
lcapelluto
reviewed
Mar 10, 2021
lcapelluto
reviewed
Mar 10, 2021
lcapelluto
reviewed
Mar 10, 2021
lcapelluto
suggested changes
Mar 10, 2021
Fixed macro code and added one more test
lcapelluto
changed the title
lcapelluto
reviewed
Mar 16, 2021
lcapelluto
reviewed
Mar 19, 2021
lcapelluto
reviewed
Mar 19, 2021
|
blocking #5577 |
lcapelluto
suggested changes
Mar 23, 2021
releasenotes/notes/update-meas-map-interpretation-53795a9bc7d42857.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/update-meas-map-interpretation-53795a9bc7d42857.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/update-meas-map-interpretation-53795a9bc7d42857.yaml
Outdated
Show resolved
Hide resolved
…2857.yaml Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com>
Updated reno and error messages Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com>
lcapelluto
approved these changes
Mar 23, 2021
lcapelluto
added
the
Changelog: Bugfix
|
I should try running on a device before adding |
lcapelluto
added
on hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The interpretation of the meas_map has historically been:
qubit<i>must be accompanied by a measurement of all qubits inmeas_map[i]The interpretation should now be
meas_map[i]may not be measured disjointly in time such that they overlap incompletely, eg., formeas_map=[[0, 1]]and duration 10.measure(0)@t=10,measure(1)@t=10is fine, butmeasure(0)@t=10,measure(1)@t=11is incorrect.measure(0)@t=10,measure(1)@t=20would be fine as they do not overlapThis must be reflected in both the circuit and pulse paths.
Details and comments
Part - 1 Fixing meas_map logic in measure of macro.py - All this used to do was add extra acquire for even unused qubits. So, if I have meas map [[0, 1]], and zero is measured, 1 ALSO gets acquired. It doesn’t need to be. This PR fixes this issue.
Part - 2 Change the way we validate schedules - The meas map is interpreted incorrectly. If I acquire only 0 or only 1, theres no problem. If I acquire both, they MUST be at the same time, or else completely disjoint (finish acquiring 0 before starting to acquire 1)
Co-authored by: Lauren Capelluto (@lcapelluto)