Add macos universal2 wheel job #6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new wheel job for building universal2 wheels for macOS. The universal2 wheels will enable running on arm64 macOS systems. As we don't have any arm64 mac hardware available in CI systems yet these jobs are cross-compiling arm64 binaries from an x86_64 mac, we also can't test the arm64 binary component as part of the job because of this. This commit also takes the opportunity to update the cibuildwheel version used for CI to the latest release 1.10.0, since we need to use >=1.9.0 for arm on macOS support.
|
@nonhermitian can you test the |
|
Seems to work just fine: Architectures in the fat file: /Users/paul/mambaforge/envs/qiskit/lib/python3.9/site-packages/qiskit/transpiler/passes/routing/cython/stochastic_swap/swap_trial.cpython-39-darwin.so are: x86_64 arm64 |
The wheel builds all worked and @nonhermitian manually tested the universal2 binary on an arm64 mac. So this commit removes the test commit to force the wheel jobs from running on the PR so this is ready to be merged. This reverts commit a9bafdd.
nonhermitian
approved these changes
Apr 18, 2021
Cryoris
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a new wheel job for building universal2 wheels for
macOS. The universal2 wheels will enable running on arm64 macOS systems.
As we don't have any arm64 mac hardware available in CI systems yet
these jobs are cross-compiling arm64 binaries from an x86_64 mac, we
also can't test the arm64 binary component as part of the job because of
this.
This commit also takes the opportunity to update the cibuildwheel
version used for CI to the latest release 1.10.0, since we need to
use >=1.9.0 for arm on macOS support.
Details and comments
Related to #1201