Fixes circuit_to_instruction() method for circuits containing single bit conditions #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TharrmashasthaPV
requested review from
nkanazawa1989,
nonhermitian and
a team
as code owners
11 tasks
TharrmashasthaPV
force-pushed
the
issue6475_circ_to_inst
branch
from
42a183a to
9b8eda6
Compare
javabster
added
the
Changelog: Bugfix
javabster
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a part of #6475.
Details and comments
This PR fixes the
circuit_to_instruction()method for circuits involving gates which are conditioned on single classical bits.Also added a test to check if the mappings of conditions based on circuit registers to conditions based on instruction registers are done right.