-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change operator comparison from np.array_equal
to np.allclose
(#6473)
#6644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwright99
changed the title
Change operator comparison from
Change operator comparison from Jun 25, 2021
np.array_equal
to np.allclose
.np.array_equal
to np.allclose
(#6473)
Looks good can you add a release note? |
levbishop
added
bug
Something isn't working
Changelog: Bugfix
Include in the "Fixed" section of the changelog
and removed
bug
Something isn't working
labels
Jul 9, 2021
@levbishop should be good now! |
levbishop
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this
kdk
added
the
stable backport potential
The bug might be minimal and/or import enough to be port to stable
label
Jul 13, 2021
mergify bot
added a commit
that referenced
this pull request
Jul 14, 2021
) (#6644) (#6739) * Change operator comparison from `np.array_equal` to `np.allclose`. * Added release notes Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 3fcc055) Co-authored-by: Matt Wright <44040188+mattwright99@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Bugfix
Include in the "Fixed" section of the changelog
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6473
Details and comments
Optimize1qGatesDecompositions
would not optimize single qubit gates if they are sufficiently close to the identity (see #6473 for example). This was fixed by replacing thenp.array_equals
function with thenp.allclose
function to compare the operator to the identity. We use an absolute threshold of1e-15
.New output: