-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fake backend kwargs #6743
Fix fake backend kwargs #6743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for pushing the quick fix
The test failure that occurred in 06fe680 (and a few before that) looks like it'll bite again - the bug is that in That said, while its unconditional skip reason no longer seems to be valid (Qiskit/qiskit-aer#741 is fixed and released), the test fails by seemingly using something out-of-date, and I don't yet have the experience with the codebase to know much about that. |
@jakelishman can you open an issue about this? I think that's a bunch of improvements we can/should make to the testing harness. At least for this case it's a simple to add the |
* fix fake backends not getting kwargs * add test * damn missing braket * move to new class * rename new class * I hate lint * Add release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 795e845)
* fix fake backends not getting kwargs * add test * damn missing braket * move to new class * rename new class * I hate lint * Add release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 795e845) Co-authored-by: Paul Nation <nonhermitian@gmail.com>
Summary
Fixes #6741
Adds kwargs to backend.run() with noise model.
Details and comments