-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gate error and balanced objective to BIP mapper #6778
Conversation
@@ -84,9 +84,9 @@ def __init__( | |||
If None, all qubits in the coupling_map will be considered. | |||
objective (str): Type of objective function: | |||
|
|||
* ``'error_rate'``: [NotImplemented] Predicted error rate of the circuit | |||
* ``'error_rate'``: Predicted error rate of the circuit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some description of how this "prediction" works? I think it multiplies gate errors, and thus it is only a function of circuit size but not depth. But just needs to be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more description on 'error_rate' objective at 0c24c75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think error_rate
is not a good name because a true error rate is a combination of gate errors and depth of circuit. This completely ignores depth. We should just call it size
. So we have "size"/"depth"/"balanced"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree "error_rate" is not a precise name and "size" is better, but "size" still sounds like a bit misleading name to me since the objective considers 2q-gate errors (not counts). How about "2qgate_error"? I think it's the most appropriate name. Is it too long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. If we want to be completely accurate in naming these objective function then even depth might not be too accurate. I'll merge this for now and if we find a better name we can replace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to "gate_error" for now.
Summary
Add
gate_error
andbalanced
objectives to the BIP mapper.Details and comments
Previously, only the
depth
objective is implemented inBIPMapping
pass. This commit adds the implement ofgate_error
andbalanced
objective functions, which are described in the original paper (https://arxiv.org/abs/2106.06446). Note thatgate_error
is referred as "error_rate" in the paper.