Fix CompleteMeasFitter not imported in QuantumInstance #6782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoelmarques
added
bug
mtreinish
added
the
stable backport potential
mtreinish
reviewed
Jul 22, 2021
There was a problem hiding this comment.
This LGTM as a workaround for the issue reported and as a backport for fixing the bug. My larger concern (which I don't think is worth blocking this on, but more something we'll need in the near future) is how to handle different types of mitigators. There is a proposed new one #6748 and a proposed common readout mitigator interface #6485 and this approach kind of ties our hands to a hard coded list of classes. But that being said this doesn't actually change the current state here, just fixes the import issue.
The only thing I think missing is a test for the case before that caused the import issue.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
approved these changes
Jul 22, 2021
woodsp-ibm
approved these changes
Jul 22, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2021
* Fix CompleteMeasFitter not imported in QuantumInstance * Update releasenotes/notes/completemeasfitter-386e94a271ba0180.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * added unit test Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit fbf389f)
mergify bot
added a commit
that referenced
this pull request
Jul 22, 2021
* Fix CompleteMeasFitter not imported in QuantumInstance * Update releasenotes/notes/completemeasfitter-386e94a271ba0180.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * added unit test Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit fbf389f) Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Fix CompleteMeasFitter not imported in QuantumInstance * Update releasenotes/notes/completemeasfitter-386e94a271ba0180.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * added unit test Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
…#6782) * Fix CompleteMeasFitter not imported in QuantumInstance * Update releasenotes/notes/completemeasfitter-386e94a271ba0180.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * added unit test Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms
that referenced
this pull request
Jul 27, 2023
…#6782) * Fix CompleteMeasFitter not imported in QuantumInstance * Update releasenotes/notes/completemeasfitter-386e94a271ba0180.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * added unit test Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6774
Fixes #6789
Details and comments