Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QNSPSA settings #6818

Merged
merged 7 commits into from
Jul 30, 2021
Merged

Fix QNSPSA settings #6818

merged 7 commits into from
Jul 30, 2021

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Jul 27, 2021

Summary

Add the missing fidelity argument in the QNSPSA.settings method.

Details and comments

Fixes the deserialization of the optimizer with the RuntimeDecoder.

@Cryoris Cryoris requested review from manoelmarques, woodsp-ibm and a team as code owners July 27, 2021 15:47
@Cryoris Cryoris added Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable labels Jul 27, 2021
jyu00
jyu00 previously approved these changes Jul 27, 2021
Copy link
Contributor

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodsp-ibm woodsp-ibm added the mod: algorithms Related to the Algorithms module label Jul 27, 2021
@mergify mergify bot merged commit b434c05 into Qiskit:main Jul 30, 2021
mergify bot pushed a commit that referenced this pull request Jul 30, 2021
* include fidelity in the settings

* add reno

* lint exception

* Remove reference to Qiskit Runtime from argument docstring

* Update release note

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit b434c05)
mergify bot added a commit that referenced this pull request Jul 30, 2021
* include fidelity in the settings

* add reno

* lint exception

* Remove reference to Qiskit Runtime from argument docstring

* Update release note

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit b434c05)

Co-authored-by: Julien Gacon <gaconju@gmail.com>
@kdk kdk added this to the 0.19 milestone Nov 15, 2021
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
* include fidelity in the settings

* add reno

* lint exception

* Remove reference to Qiskit Runtime from argument docstring

* Update release note

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
* include fidelity in the settings

* add reno

* lint exception

* Remove reference to Qiskit Runtime from argument docstring

* Update release note

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: algorithms Related to the Algorithms module stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants