-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix QNSPSA settings #6818
Merged
Merged
Fix QNSPSA settings #6818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
manoelmarques,
woodsp-ibm and
a team
as code owners
July 27, 2021 15:47
Cryoris
added
Changelog: Bugfix
Include in the "Fixed" section of the changelog
stable backport potential
The bug might be minimal and/or import enough to be port to stable
labels
Jul 27, 2021
jyu00
previously approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
woodsp-ibm
reviewed
Jul 27, 2021
mtreinish
approved these changes
Jul 29, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
* include fidelity in the settings * add reno * lint exception * Remove reference to Qiskit Runtime from argument docstring * Update release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit b434c05)
mergify bot
added a commit
that referenced
this pull request
Jul 30, 2021
* include fidelity in the settings * add reno * lint exception * Remove reference to Qiskit Runtime from argument docstring * Update release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit b434c05) Co-authored-by: Julien Gacon <gaconju@gmail.com>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* include fidelity in the settings * add reno * lint exception * Remove reference to Qiskit Runtime from argument docstring * Update release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* include fidelity in the settings * add reno * lint exception * Remove reference to Qiskit Runtime from argument docstring * Update release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Bugfix
Include in the "Fixed" section of the changelog
mod: algorithms
Related to the Algorithms module
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the missing
fidelity
argument in theQNSPSA.settings
method.Details and comments
Fixes the deserialization of the optimizer with the
RuntimeDecoder
.