filter_function for circuit.depth() and circuit.size() #6998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
reviewed
Sep 9, 2021
|
|
||
| Args: | ||
| filter_function (callable): a function to filter out some instructions. | ||
| Should take as input a tuple of (Instruction, list(Qubit), list(Clbit)). |
There was a problem hiding this comment.
I'm wondering if it makes more sense to flatten this one layer and use 3 positional args. It might be easier for people to create functions like:
def filter_fn(instruction, qargs, cargs):instead of:
def filter_fn(inst_tuple):
instruction = inst_tuple[0]
qargs = inst_tuple[1]
cargs = inst_tuple[2]There was a problem hiding this comment.
I intentionally did it this way because I think we really need something in Qiskit to represent the tuple (inst, qubit, clbits). I was actually going to do that as a followup, using a namedtuple or something. It comes up over and over again that you need the operation plus the operands. I think that is the basic unit of a circuit (i.e. one line of qasm).
mtreinish
added
the
Changelog: New Feature
ajavadia
commented
Sep 9, 2021
ecpeterson
reviewed
Sep 9, 2021
ecpeterson
previously requested changes
Sep 9, 2021
ajavadia
force-pushed
the
circuit-depth-size
branch
from
0ab5692 to
9668618
Compare
ajavadia
force-pushed
the
circuit-depth-size
branch
from
9668618 to
56590dd
Compare
ecpeterson
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding the ability to filter by instructions when inquiring circuit.depth() or circuit.size()
closes #6702