Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 #7295

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Drop support for Python 3.6 #7295

merged 3 commits into from
Dec 6, 2021

Conversation

mtreinish
Copy link
Member

Summary

As has been advertised for some time the Qiskit 0.19.0 release is the
last release which supports Python 3.6 (which goes End of Life in
December). This commit drops support accordingly so that the minimum
supported Python version is 3.7.

Details and comments

As has been advertised for some time the Qiskit 0.19.0 release is the
last release which supports Python 3.6 (which goes End of Life in
Decemeber). This commit drops support accordingly so that the minimum
supported Python version is 3.7.
@mtreinish mtreinish added the on hold Can not fix yet label Nov 19, 2021
@mtreinish mtreinish added this to the 0.20 milestone Nov 19, 2021
@mtreinish mtreinish requested a review from a team as a code owner November 19, 2021 21:00
@mtreinish
Copy link
Member Author

People keep asking when this is going to happen so I decided to push a PR for it
so I can link people to it (and save some typing). But this is blocked from merging
until 0.19.0 is released (which should be soon). Once we bump the version number
to 0.20.0 on main we can merge this as the first commit for 0.20.0

@coveralls
Copy link

coveralls commented Nov 19, 2021

Pull Request Test Coverage Report for Build 1546759712

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.007%) to 83.094%

Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/uc.py 2 88.65%
qiskit/pulse/library/waveform.py 3 89.36%
Totals Coverage Status
Change from base Build 1546753217: -0.007%
Covered Lines: 51667
Relevant Lines: 62179

💛 - Coveralls

jakelishman
jakelishman previously approved these changes Nov 23, 2021
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(preemptive approval)

There are several goodies to do with type-checking that we'll be able to use once Python 3.7 support is dropped, including from __future__ import annotations, which removes all the need for string-ified type annotations.

From now on, we can also rely on dictionaries to be in insertion-order, which I think has come up before with respect to Result.get_counts() and things like that. We also get module-level __getattr__, which is something we've definitely had usecases for as well (though perhaps we should be cautious with that one, since it will have a tendency to break auto-complete).

@jakelishman jakelishman removed the on hold Can not fix yet label Dec 6, 2021
@jakelishman
Copy link
Member

Removing on hold, because this is now eligible for merge.

@mtreinish mtreinish added the Changelog: Removal Include in the Removed section of the changelog label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants