-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copying control-flow bodies in builder interface #7368
Merged
mergify
merged 2 commits into
Qiskit:main
from
jakelishman:fix/control-flow-builder-parameter-copy
Dec 7, 2021
Merged
Fix copying control-flow bodies in builder interface #7368
mergify
merged 2 commits into
Qiskit:main
from
jakelishman:fix/control-flow-builder-parameter-copy
Dec 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few places where the structure of an element of `QuantumCircuit.data` is specifically assumed to be Tuple[Instruction, List[Qubit], List[Clbit]] rather than the more abstract Tuple[Instruction, Sequence[Qubit], Sequence[Clbit]] For performance reasons, the control-flow builders used tuples to store their arguments internally, because this prevents any copying being necessary, and allows the arguments to be put in sets. Now, in lieu of changing the `QuantumCircuit` data structure to be more abstract, which would have performance implications, or to require the tuples, which may create more bugs, we just make the builder interface convert its tuples to lists on output.
jakelishman
added
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Changelog: Bugfix
Include in the "Fixed" section of the changelog
circuit-builder
labels
Dec 7, 2021
Pull Request Test Coverage Report for Build 1551115436
💛 - Coveralls |
kevinhartman
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2021
There are a few places where the structure of an element of `QuantumCircuit.data` is specifically assumed to be Tuple[Instruction, List[Qubit], List[Clbit]] rather than the more abstract Tuple[Instruction, Sequence[Qubit], Sequence[Clbit]] For performance reasons, the control-flow builders used tuples to store their arguments internally, because this prevents any copying being necessary, and allows the arguments to be put in sets. Now, in lieu of changing the `QuantumCircuit` data structure to be more abstract, which would have performance implications, or to require the tuples, which may create more bugs, we just make the builder interface convert its tuples to lists on output. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit d38620a)
mergify bot
added a commit
that referenced
this pull request
Dec 8, 2021
There are a few places where the structure of an element of `QuantumCircuit.data` is specifically assumed to be Tuple[Instruction, List[Qubit], List[Clbit]] rather than the more abstract Tuple[Instruction, Sequence[Qubit], Sequence[Clbit]] For performance reasons, the control-flow builders used tuples to store their arguments internally, because this prevents any copying being necessary, and allows the arguments to be put in sets. Now, in lieu of changing the `QuantumCircuit` data structure to be more abstract, which would have performance implications, or to require the tuples, which may create more bugs, we just make the builder interface convert its tuples to lists on output. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit d38620a) Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Bugfix
Include in the "Fixed" section of the changelog
circuit-builder
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are a few places where the structure of an element of
QuantumCircuit.data
is specifically assumed to berather than the more abstract
For performance reasons, the control-flow builders used tuples to store
their arguments internally, because this prevents any copying being
necessary, and allows the arguments to be put in sets. Now, in lieu of
changing the
QuantumCircuit
data structure to be more abstract, whichwould have performance implications, or to require the tuples, which may
create more bugs, we just make the builder interface convert its tuples
to lists on output.
Details and comments
A relatively hidden bug, but a bug nonetheless, and fixing this will make it much easier for Aer to write its test cases for 0.10. @hhorii.
Fix #7367.