Reinstate and deprecate loose measure and reset functions #7376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `QuantumCircuit` methods `.measure` and `.reset` were defined as regular functions in `circuit/measure.py` (m.m. `reset`) and monkey-patched onto `QuantumCircuit`. Commit 2cd42b4 removed the monkey-patching by defining them as regular methods, but did not implement a deprecation period for the functions. This reinstates them, with the deprecation warning.
jakelishman
added
Changelog: Bugfix
Pull Request Test Coverage Report for Build 1553934524
💛 - Coveralls |
mtreinish
approved these changes
Dec 8, 2021
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
Previously, the `QuantumCircuit` methods `.measure` and `.reset` were defined as regular functions in `circuit/measure.py` (m.m. `reset`) and monkey-patched onto `QuantumCircuit`. Commit 2cd42b4 removed the monkey-patching by defining them as regular methods, but did not implement a deprecation period for the functions. This reinstates them, with the deprecation warning. (cherry picked from commit 89b324c)
mergify bot
added a commit
that referenced
this pull request
Dec 8, 2021
) Previously, the `QuantumCircuit` methods `.measure` and `.reset` were defined as regular functions in `circuit/measure.py` (m.m. `reset`) and monkey-patched onto `QuantumCircuit`. Commit 2cd42b4 removed the monkey-patching by defining them as regular methods, but did not implement a deprecation period for the functions. This reinstates them, with the deprecation warning. (cherry picked from commit 89b324c) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the
QuantumCircuitmethods.measureand.resetweredefined as regular functions in
circuit/measure.py(m.m.reset) andmonkey-patched onto
QuantumCircuit. Commit 2cd42b4 removed themonkey-patching by defining them as regular methods, but did not
implement a deprecation period for the functions. This reinstates them,
with the deprecation warning.
Details and comments
Fix #7370. This came up on
pennylane_qiskit: see PennyLaneAI/pennylane-qiskit#164.