Fix InverseCancellation pass to handle gates of different names. #7383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in QiskitGH-7378, the InverseCancellation optimization pass previously assumed that inverse gate pairs would always share a common name, but this is not universally true. This commit updates the pass to search for runs containing any of the gate names in the gates_to_cancel list, instead of only the first. Co-authored-by: Bruno Schmitt <bruno.schmitt@epfl.ch>
kdk
added
stable backport potential
mtreinish
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
This LGTM, this was clearly a bug assuming the names were equal for inverse pairs so this is the simple fix that we can easily backport for 0.19.1. But, I also agree with @boschmitt in #7378 having a way to transform things into a canonical form is probably a good/better way to handle this longer term as part of 0.20.0.
Pull Request Test Coverage Report for Build 1556245160
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
As reported in GH-7378, the InverseCancellation optimization pass previously assumed that inverse gate pairs would always share a common name, but this is not universally true. This commit updates the pass to search for runs containing any of the gate names in the gates_to_cancel list, instead of only the first. Co-authored-by: Bruno Schmitt <bruno.schmitt@epfl.ch> Co-authored-by: Bruno Schmitt <bruno.schmitt@epfl.ch> (cherry picked from commit d9ab98f)
mergify bot
added a commit
that referenced
this pull request
Dec 9, 2021
…) (#7384) As reported in GH-7378, the InverseCancellation optimization pass previously assumed that inverse gate pairs would always share a common name, but this is not universally true. This commit updates the pass to search for runs containing any of the gate names in the gates_to_cancel list, instead of only the first. Co-authored-by: Bruno Schmitt <bruno.schmitt@epfl.ch> Co-authored-by: Bruno Schmitt <bruno.schmitt@epfl.ch> (cherry picked from commit d9ab98f) Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in GH-7378, the InverseCancellation optimization pass
previously assumed that inverse gate pairs would always share a
common name, but this is not universally true. This commit updates
the pass to search for runs containing any of the gate names in the
gates_to_cancel list, instead of only the first.
Co-authored-by: Bruno Schmitt bruno.schmitt@epfl.ch
Summary
Details and comments