-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add durations of pulse gates from DAG calibrations #7463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edule in the calibration to node.op.duration
Pull Request Test Coverage Report for Build 1731452580
💛 - Coveralls |
lcapelluto
reviewed
Jan 7, 2022
lcapelluto
approved these changes
Jan 11, 2022
1 task
jakelishman
added
the
Changelog: Bugfix
Include in the "Fixed" section of the changelog
label
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Bugfix
Include in the "Fixed" section of the changelog
mod: pulse
Related to the Pulse module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The scheduling passes of the transpiler need to be informed of the durations of the gates. In the case of pulse gates, these durations need to be added from
dag.calibrations
to thenode.op
. The following PR fixes this by checking to see if a calibration exists indag.calibrations
fornode.op.name
and if so addsnode.op.duration
from it.Details and comments
Ideally I would have used
dag.has_calibration_for(node)
to check for the existence of a calibration, but found the method did not always work. Perhaps I will raise this in a separate issue.This additionally fixes an issue where a bound
ParameterExpression
is passed to a calibration builder by casting it to afloat
.