Fix error in Target non-global operation method with ideal gates #7554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in the Target get_non_global_operation_names() method. Previously this method would crash when you had a target with it's instruction properties set to None (which is typically used for an ideal simulator).
mtreinish
added
Changelog: Bugfix
Pull Request Test Coverage Report for Build 1740055295
💛 - Coveralls |
This commit fixes an issue when running transpile() with a BackendV2 based backend that has ideal operation defined in it's target. A Target that has an operation with its qargs set as None means it's ideally defined on all qubits (or all combinations of qubits for >1 qubit operations). However, the pre-processing of the target in the transpile() method was not taking this into account and would fail if a backend with this set was used.
In the previous commit there were some issues in the tweaks made to the transpile() function to parse the timing_constraints argument. The basic flow we wanted for the standalone target case is to create a TimingConstraints object directly from that Target. However, the internal function was expect only a dict was passed in and tried to create a TimingConstraints object from it. The previous commit tried to address this but neglected the standard use with a dict. This commit corrects this oversight and tweaks the logic to handle a predefined TimingConstraint object first and then fallsback to the other behavior.
jakelishman
approved these changes
Jan 24, 2022
Comment on lines
545
to
+549
| if target is not None: | ||
| if coupling_map is None: | ||
| coupling_map = target.coupling_map() | ||
| coupling_map = target.build_coupling_map() | ||
| if basis_gates is None: | ||
| basis_gates = target.operation_names() | ||
| basis_gates = target.operation_names |
There was a problem hiding this comment.
If there were type hints in this function, pylint would have caught this ;)
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2022
* Fix error in Target non-global operation method with ideal gates This commit fixes an issue in the Target get_non_global_operation_names() method. Previously this method would crash when you had a target with it's instruction properties set to None (which is typically used for an ideal simulator). * Fix issue with transpile() on BackendV2 with ideal operation This commit fixes an issue when running transpile() with a BackendV2 based backend that has ideal operation defined in it's target. A Target that has an operation with its qargs set as None means it's ideally defined on all qubits (or all combinations of qubits for >1 qubit operations). However, the pre-processing of the target in the transpile() method was not taking this into account and would fail if a backend with this set was used. * Tweak timing constraints parsing in transpile() In the previous commit there were some issues in the tweaks made to the transpile() function to parse the timing_constraints argument. The basic flow we wanted for the standalone target case is to create a TimingConstraints object directly from that Target. However, the internal function was expect only a dict was passed in and tried to create a TimingConstraints object from it. The previous commit tried to address this but neglected the standard use with a dict. This commit corrects this oversight and tweaks the logic to handle a predefined TimingConstraint object first and then fallsback to the other behavior. (cherry picked from commit fe5acd4)
mergify bot
added a commit
that referenced
this pull request
Jan 24, 2022
…) (#7561) * Fix error in Target non-global operation method with ideal gates This commit fixes an issue in the Target get_non_global_operation_names() method. Previously this method would crash when you had a target with it's instruction properties set to None (which is typically used for an ideal simulator). * Fix issue with transpile() on BackendV2 with ideal operation This commit fixes an issue when running transpile() with a BackendV2 based backend that has ideal operation defined in it's target. A Target that has an operation with its qargs set as None means it's ideally defined on all qubits (or all combinations of qubits for >1 qubit operations). However, the pre-processing of the target in the transpile() method was not taking this into account and would fail if a backend with this set was used. * Tweak timing constraints parsing in transpile() In the previous commit there were some issues in the tweaks made to the transpile() function to parse the timing_constraints argument. The basic flow we wanted for the standalone target case is to create a TimingConstraints object directly from that Target. However, the internal function was expect only a dict was passed in and tried to create a TimingConstraints object from it. The previous commit tried to address this but neglected the standard use with a dict. This commit corrects this oversight and tweaks the logic to handle a predefined TimingConstraint object first and then fallsback to the other behavior. (cherry picked from commit fe5acd4) Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes an issue in the Target
get_non_global_operation_names() method. Previously this method would
crash when you had a target with it's instruction properties set to
None (which is typically used for an ideal simulator).
Details and comments