-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use manylinux2014 on all Linux builds #7566
Conversation
Numpy and Scipy are moving to drop manylinux2010 wheels on newer platforms, which gives us some cover to do the same. To test, we need to ensure that we pull Numpy and Scipy in binary form only (forcing pip to install slightly older versions like 1.21 instead of 1.22 on unsupported Python versions), rather than attempting to build Numpy from source as part of our testing process.
Pull Request Test Coverage Report for Build 1750130443
💛 - Coveralls |
786a0f1
to
7b89b0a
Compare
manylinux-x86_64-image = "manylinux2014" | ||
manylinux-i686-image = "manylinux2014" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is implicit in cibuildwheel > 2.3 which is why I avoided upgrading it earlier. While we're updating things I think it's good to bump our cibuildwheel version too. It's fine to keep this here too though and be explicit about the version we're using, but maybe we should pull in the latest cibuildwheel release now too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed up a new commit to bump the version of cibuildwheel, but I've left this explicit setting of the manylinux
images in place. It's probably clearer for the team in general if we're explicit, rather than relying on the default behaviour.
d6767ab
to
45a5032
Compare
Ready for final review. Newer versions of cibuildwheel are now tagging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looking at the CI logs for linux: https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=33941&view=logs&j=8cafc477-7e80-59f4-bd23-af61455d1e35&t=c0730c84-3b34-5463-af55-a8d174d10004 everything looks correct.
When we release 0.20.0 we'll have to remember to update: https://qiskit.org/documentation/getting_started.html#platform-support to say manylinux2014 everywhere
Good point - I forgot that we now have more descriptive documentation about platform support! |
Summary
Numpy and Scipy are moving to drop manylinux2010 wheels on newer
platforms, which gives us some cover to do the same. To test, we need
to ensure that we pull Numpy and Scipy in binary form only (forcing pip
to install slightly older versions like 1.21 instead of 1.22 on
unsupported Python versions), rather than attempting to build Numpy from
source as part of our testing process.
Details and comments
We are going to deploy 0.19.2 with manylinux2014 for Python 3.10, since we don't have any prior commitments in the 0.19 series for Python 3.10, but we left raising the VM on other Pythons until the next minor. Given that we really don't use much of the C API, there won't be any huge improvement from upping the VM, but it'll be easier for us to keep pace with Numpy and Scipy going forwards.