Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manylinux2014 on all Linux builds #7566

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

jakelishman
Copy link
Member

Summary

Numpy and Scipy are moving to drop manylinux2010 wheels on newer
platforms, which gives us some cover to do the same. To test, we need
to ensure that we pull Numpy and Scipy in binary form only (forcing pip
to install slightly older versions like 1.21 instead of 1.22 on
unsupported Python versions), rather than attempting to build Numpy from
source as part of our testing process.

Details and comments

We are going to deploy 0.19.2 with manylinux2014 for Python 3.10, since we don't have any prior commitments in the 0.19 series for Python 3.10, but we left raising the VM on other Pythons until the next minor. Given that we really don't use much of the C API, there won't be any huge improvement from upping the VM, but it'll be easier for us to keep pace with Numpy and Scipy going forwards.

Numpy and Scipy are moving to drop manylinux2010 wheels on newer
platforms, which gives us some cover to do the same.  To test, we need
to ensure that we pull Numpy and Scipy in binary form only (forcing pip
to install slightly older versions like 1.21 instead of 1.22 on
unsupported Python versions), rather than attempting to build Numpy from
source as part of our testing process.
@jakelishman jakelishman added the Changelog: API Change Include in the "Changed" section of the changelog label Jan 25, 2022
@jakelishman jakelishman added this to the 0.20 milestone Jan 25, 2022
@coveralls
Copy link

coveralls commented Jan 25, 2022

Pull Request Test Coverage Report for Build 1750130443

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.174%

Totals Coverage Status
Change from base Build 1749907462: 0.0%
Covered Lines: 52032
Relevant Lines: 62558

💛 - Coveralls

@mtreinish mtreinish self-assigned this Jan 25, 2022
@jakelishman jakelishman marked this pull request as ready for review January 25, 2022 17:36
@jakelishman jakelishman requested a review from a team as a code owner January 25, 2022 17:36
Comment on lines +9 to +10
manylinux-x86_64-image = "manylinux2014"
manylinux-i686-image = "manylinux2014"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is implicit in cibuildwheel > 2.3 which is why I avoided upgrading it earlier. While we're updating things I think it's good to bump our cibuildwheel version too. It's fine to keep this here too though and be explicit about the version we're using, but maybe we should pull in the latest cibuildwheel release now too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed up a new commit to bump the version of cibuildwheel, but I've left this explicit setting of the manylinux images in place. It's probably clearer for the team in general if we're explicit, rather than relying on the default behaviour.

@jakelishman
Copy link
Member Author

jakelishman commented Jan 26, 2022

Ready for final review. Newer versions of cibuildwheel are now tagging manylinux2010 and manylinux2014 wheels with the new manylinux_major_minor format as well (in a composite tag), which is good - that's a bit more future-proof for us.

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking at the CI logs for linux: https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=33941&view=logs&j=8cafc477-7e80-59f4-bd23-af61455d1e35&t=c0730c84-3b34-5463-af55-a8d174d10004 everything looks correct.

When we release 0.20.0 we'll have to remember to update: https://qiskit.org/documentation/getting_started.html#platform-support to say manylinux2014 everywhere

@mergify mergify bot merged commit 01913f4 into Qiskit:main Jan 26, 2022
@jakelishman jakelishman deleted the py310-manylinux2014 branch January 26, 2022 14:22
@jakelishman
Copy link
Member Author

Good point - I forgot that we now have more descriptive documentation about platform support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: API Change Include in the "Changed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants