Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamical Decoupling pass with pulse alignment #7760

Merged
merged 12 commits into from
Mar 22, 2022

Conversation

nkanazawa1989
Copy link
Contributor

Summary

In recent IBM Quantum systems all pulses should start at the multiple value of 16 dt which is called pulse alignment constraint. This PR adds alignment constraint to the DD pass so that circuit with the DD sequence can be played on the actual hardware. The pass is initialized with pulse_alignment which defaults to 1, but you can give the value imposed by the backend. You can find this value in backend.configuration().timing_constraints.

Details and comments

There are several internal changes.

  • DD pass is now subclass of BasePaddingpass. This means DD is a drop-in-replacement of PadDelay pass.
  • Now _pad method is called with t0 and t1 instead of interval. This is for future extendability for the conditioning.
  • Extra slack is now distributed to the edges of the sequence rather than to the interval in the middle.
  • The import path of DD pass is upgraded (but still under the same place in transpiler.passes.

Now DD pass is a subclass of padding pass. DD pass takes pulse alignment constraints to execute circuit on recent RTA systems.

There are small changes to the base padding pass to host this pass as a subclass. .pad method is now called with (t0, t1) instead of interval. In addition, pre_runhook method is added which is called before running the padding protocol.
@nkanazawa1989 nkanazawa1989 requested a review from ajavadia March 10, 2022 15:55
@nkanazawa1989 nkanazawa1989 requested a review from a team as a code owner March 10, 2022 15:55
@mtreinish mtreinish added this to the 0.20 milestone Mar 10, 2022
@mtreinish mtreinish added priority: high Changelog: New Feature Include in the "Added" section of the changelog labels Mar 10, 2022
@coveralls
Copy link

coveralls commented Mar 10, 2022

Pull Request Test Coverage Report for Build 2022583134

  • 130 of 138 (94.2%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 83.525%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/transpiler/passes/scheduling/base_padding.py 22 24 91.67%
qiskit/transpiler/passes/scheduling/dynamical_decoupling.py 92 98 93.88%
Totals Coverage Status
Change from base Build 2018409982: 0.007%
Covered Lines: 52568
Relevant Lines: 62937

💛 - Coveralls

test/python/transpiler/test_dynamical_decoupling.py Outdated Show resolved Hide resolved
test/python/transpiler/test_dynamical_decoupling.py Outdated Show resolved Hide resolved
qiskit/transpiler/passes/scheduling/padding.py Outdated Show resolved Hide resolved
qiskit/transpiler/passes/scheduling/padding.py Outdated Show resolved Hide resolved
qiskit/transpiler/passes/scheduling/padding.py Outdated Show resolved Hide resolved
qiskit/transpiler/passes/scheduling/padding.py Outdated Show resolved Hide resolved
Co-authored-by: Ali Javadi-Abhari <ajavadia@users.noreply.github.com>
@nkanazawa1989 nkanazawa1989 force-pushed the upgrade/dd-pass-as-padding branch from f48c779 to 1d1e2a5 Compare March 11, 2022 02:31
@nkanazawa1989 nkanazawa1989 force-pushed the upgrade/dd-pass-as-padding branch from b271472 to 763fa33 Compare March 11, 2022 03:34
@nkanazawa1989 nkanazawa1989 force-pushed the upgrade/dd-pass-as-padding branch from 8235ed4 to 7c27a85 Compare March 13, 2022 02:51
Co-authored-by: Ali Javadi-Abhari <ajavadia@users.noreply.github.com>
@nkanazawa1989 nkanazawa1989 force-pushed the upgrade/dd-pass-as-padding branch from 5ae747d to 997049f Compare March 14, 2022 16:38
Copy link
Member

@ajavadia ajavadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@mergify mergify bot merged commit 04f912b into Qiskit:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants