-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamical Decoupling pass with pulse alignment #7760
Merged
mergify
merged 12 commits into
Qiskit:main
from
nkanazawa1989:upgrade/dd-pass-as-padding
Mar 22, 2022
Merged
Dynamical Decoupling pass with pulse alignment #7760
mergify
merged 12 commits into
Qiskit:main
from
nkanazawa1989:upgrade/dd-pass-as-padding
Mar 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now DD pass is a subclass of padding pass. DD pass takes pulse alignment constraints to execute circuit on recent RTA systems. There are small changes to the base padding pass to host this pass as a subclass. .pad method is now called with (t0, t1) instead of interval. In addition, pre_runhook method is added which is called before running the padding protocol.
mtreinish
added
priority: high
Changelog: New Feature
Include in the "Added" section of the changelog
labels
Mar 10, 2022
Pull Request Test Coverage Report for Build 2022583134
💛 - Coveralls |
2 tasks
ajavadia
reviewed
Mar 10, 2022
releasenotes/notes/dynamical-decoupling-with-alignment-9c1e5ee909eab0f7.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/dynamical-decoupling-with-alignment-9c1e5ee909eab0f7.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/dynamical-decoupling-with-alignment-9c1e5ee909eab0f7.yaml
Outdated
Show resolved
Hide resolved
nkanazawa1989
force-pushed
the
upgrade/dd-pass-as-padding
branch
from
March 11, 2022 02:31
f48c779
to
1d1e2a5
Compare
nkanazawa1989
force-pushed
the
upgrade/dd-pass-as-padding
branch
from
March 11, 2022 03:34
b271472
to
763fa33
Compare
itoko
reviewed
Mar 11, 2022
ajavadia
reviewed
Mar 11, 2022
nkanazawa1989
force-pushed
the
upgrade/dd-pass-as-padding
branch
from
March 13, 2022 02:51
8235ed4
to
7c27a85
Compare
ajavadia
reviewed
Mar 14, 2022
Co-authored-by: Ali Javadi-Abhari <ajavadia@users.noreply.github.com>
nkanazawa1989
force-pushed
the
upgrade/dd-pass-as-padding
branch
from
March 14, 2022 16:38
5ae747d
to
997049f
Compare
ajavadia
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In recent IBM Quantum systems all pulses should start at the multiple value of 16 dt which is called pulse alignment constraint. This PR adds alignment constraint to the DD pass so that circuit with the DD sequence can be played on the actual hardware. The pass is initialized with
pulse_alignment
which defaults to 1, but you can give the value imposed by the backend. You can find this value inbackend.configuration().timing_constraints
.Details and comments
There are several internal changes.
BasePadding
pass. This means DD is a drop-in-replacement ofPadDelay
pass._pad
method is called with t0 and t1 instead of interval. This is for future extendability for the conditioning.transpiler.passes
.