Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAGCircuit._copy_circuit_metadata is widely used and it should be public #7803

Merged
merged 15 commits into from
Mar 25, 2022
Merged

DAGCircuit._copy_circuit_metadata is widely used and it should be public #7803

merged 15 commits into from
Mar 25, 2022

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Mar 22, 2022

It seems like several passes are using DAGCircuit._copy_circuit_metadata:

$ grep -rI _copy_circuit_metadata qiskit/transpiler/  | wc
       7      28     746

and another one coming.

Since the method is public de facto, I think it is time to make it official.

@1ucian0 1ucian0 requested a review from a team as a code owner March 22, 2022 16:43
@1ucian0 1ucian0 mentioned this pull request Mar 22, 2022
Closed
@mtreinish mtreinish added the Changelog: New Feature Include in the "Added" section of the changelog label Mar 22, 2022
@coveralls
Copy link

coveralls commented Mar 22, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2040095800

  • 10 of 11 (90.91%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 83.564%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/dagcircuit/dagcircuit.py 5 6 83.33%
Totals Coverage Status
Change from base Build 2036647088: 0.004%
Covered Lines: 52752
Relevant Lines: 63128
💛 - Coveralls

1ucian0 added 3 commits March 22, 2022 22:06
@1ucian0
Merge branch '_copy_circuit_metadata' of github.com:1ucian0/qiskit-te…
3b23328 
…rra; branch 'main' of github.com:Qiskit/qiskit-terra into _copy_circuit_metadata
@1ucian0
copy_empty_like
21f770f
@1ucian0
reno
7e5f6e1
Cryoris
Cryoris approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit df2a6eb into Qiskit:main Mar 25, 2022
@1ucian0 1ucian0 deleted the _copy_circuit_metadata branch March 30, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish left review comments

@Cryoris Cryoris Cryoris approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1ucian0 @coveralls @mtreinish @Cryoris @jakelishman