Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Clifford, Pauli, CNOTDihedral to handle Delay #7850

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

chriseclectic
Copy link
Member

@chriseclectic chriseclectic commented Mar 31, 2022

Summary

Fixes the Clifford, Pauli and CNOTDihedreal operator classes to handle conversion of circuits containing Delay instructions. These instructions are ignored (treated as identity) when converting to operators.

Details and comments

This fix is related to fixing an issue in qiskit-experiments: qiskit-community/qiskit-experiments#727

@chriseclectic chriseclectic added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Mar 31, 2022
@chriseclectic chriseclectic requested review from a team and ikkoham as code owners March 31, 2022 15:07
mtreinish
mtreinish previously approved these changes Mar 31, 2022
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems straightforward enough

@coveralls
Copy link

coveralls commented Mar 31, 2022

Pull Request Test Coverage Report for Build 2074181639

  • 11 of 12 (91.67%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 83.716%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/quantum_info/operators/dihedral/dihedral_circuits.py 5 6 83.33%
Totals Coverage Status
Change from base Build 2074119231: 0.02%
Covered Lines: 53990
Relevant Lines: 64492

💛 - Coveralls

@mtreinish mtreinish added stable backport potential The bug might be minimal and/or import enough to be port to stable and removed automerge labels Mar 31, 2022
@jakelishman jakelishman added this to the 0.20.1 milestone Mar 31, 2022
Fixes the Clifford, Pauli and CNOTDihedreal operator classes to handle conversion of circuits containing Delay instructions. These instructions are ignored (treated as identity) when converting to operators.
@mergify mergify bot merged commit 9c91b6e into Qiskit:main Apr 1, 2022
mergify bot pushed a commit that referenced this pull request Apr 1, 2022
* Fixes Clifford,Pauli,CNOTDihedreal to handle Delay

Fixes the Clifford, Pauli and CNOTDihedreal operator classes to handle conversion of circuits containing Delay instructions. These instructions are ignored (treated as identity) when converting to operators.

* black

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 9c91b6e)
mergify bot added a commit that referenced this pull request Apr 1, 2022
* Fixes Clifford,Pauli,CNOTDihedreal to handle Delay

Fixes the Clifford, Pauli and CNOTDihedreal operator classes to handle conversion of circuits containing Delay instructions. These instructions are ignored (treated as identity) when converting to operators.

* black

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 9c91b6e)

Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants