-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Clifford, Pauli, CNOTDihedral to handle Delay #7850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
added
the
Changelog: Bugfix
Include in the "Fixed" section of the changelog
label
Mar 31, 2022
mtreinish
previously approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems straightforward enough
Pull Request Test Coverage Report for Build 2074181639
💛 - Coveralls |
mtreinish
added
stable backport potential
The bug might be minimal and/or import enough to be port to stable
and removed
automerge
labels
Mar 31, 2022
Fixes the Clifford, Pauli and CNOTDihedreal operator classes to handle conversion of circuits containing Delay instructions. These instructions are ignored (treated as identity) when converting to operators.
chriseclectic
force-pushed
the
clifford-delay
branch
from
March 31, 2022 16:25
95464be
to
ef72b83
Compare
mtreinish
approved these changes
Mar 31, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
* Fixes Clifford,Pauli,CNOTDihedreal to handle Delay Fixes the Clifford, Pauli and CNOTDihedreal operator classes to handle conversion of circuits containing Delay instructions. These instructions are ignored (treated as identity) when converting to operators. * black Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9c91b6e)
mergify bot
added a commit
that referenced
this pull request
Apr 1, 2022
* Fixes Clifford,Pauli,CNOTDihedreal to handle Delay Fixes the Clifford, Pauli and CNOTDihedreal operator classes to handle conversion of circuits containing Delay instructions. These instructions are ignored (treated as identity) when converting to operators. * black Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9c91b6e) Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Bugfix
Include in the "Fixed" section of the changelog
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Clifford, Pauli and CNOTDihedreal operator classes to handle conversion of circuits containing Delay instructions. These instructions are ignored (treated as identity) when converting to operators.
Details and comments
This fix is related to fixing an issue in qiskit-experiments: qiskit-community/qiskit-experiments#727