Add support for non-hermitian operators in AerPauliExpectation #7857
+54
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Qiskit#415 QEOM creates a dictionary of operators to evaluate on the groundstate. When using the noisy simulators (qasm_simulator or aer_simulator), one could either use PauliExpectation (with noise) or AerPauliExpectation (without noise). PauliExpectation works with non-hermitian operators but internal methods of AerPauliExpectation raised an Error. This is a workaround to this limitation. Note that using include_custom=True on qasm allows the VQE to use a local AerPauliExpectation without using the "expectation" input. This does not apply to QEOM and one should explicitly define the "expectation" input of the VQE for it to apply globally.
Anthony-Gandon
requested review from
a team,
manoelmarques,
woodsp-ibm and
ikkoham
as code owners
|
|
|
Hi Anthony, could you add a test that checks that the |
Cryoris
added
Changelog: New Feature
Fixes Qiskit#415 QEOM creates a dictionary of operators to evaluate on the groundstate. When using the noisy simulators (qasm_simulator or aer_simulator), one could either use PauliExpectation (with noise) or AerPauliExpectation (without noise). PauliExpectation works with non-hermitian operators but internal methods of AerPauliExpectation raised an Error. This is a workaround to this limitation. Note that using include_custom=True on qasm allows the VQE to use a local AerPauliExpectation without using the "expectation" input. This does not apply to QEOM and one should explicitly define the "expectation" input of the VQE for it to apply globally.
… into qeom_commit_aerpauliexpectation # Conflicts: # qiskit/opflow/expectations/aer_pauli_expectation.py
… into qeom_commit_aerpauliexpectation # Conflicts: # qiskit/opflow/expectations/aer_pauli_expectation.py
… into qeom_commit_aerpauliexpectation
… into qeom_commit_aerpauliexpectation # Conflicts: # test/python/opflow/test_aer_pauli_expectation.py
Cryoris
reviewed
Apr 1, 2022
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Use a generator instead of list
|
I changed the line giving the pylint error (I thought It was only a warning at first). Basically just all(k.is_hermitian() for k in ...) instead of all([k.is_hermitian() for k in ...]) |
Pull Request Test Coverage Report for Build 2115065714
💛 - Coveralls |
Cryoris
reviewed
Apr 7, 2022
releasenotes/notes/add-support-non-hermitian-op-aerpauliexpectation-653d8e16de4eca07.yaml
Outdated
Show resolved
Hide resolved
| """pauli expect state vector with non hermitian operator test""" | ||
| states_op = ListOp([One, Zero, Plus, Minus]) | ||
|
|
||
| op = np.array([[0, 1], [2, 3]]) |
There was a problem hiding this comment.
Should we add a test for other primitives than MatrixOp? What about e.g. 1j * Y as non-hermitian operator?
There was a problem hiding this comment.
A test case was added with the primitive PauliOp (I used 1jX because with 1jY all the expected values for Plus, Minus, 0, 1 were null). The names of the two test cases were adapted consequently.
Co-authored-by: Julien Gacon <gaconju@gmail.com>
…ation-653d8e16de4eca07.yaml Co-authored-by: Julien Gacon <gaconju@gmail.com>
Cryoris
reviewed
Apr 7, 2022
|
|
||
| op = 1j * X | ||
|
|
||
| converted_meas = self.expect.convert(~StateFn(op) @ states_op) |
There was a problem hiding this comment.
Using ~ will complex conjugate the observable, which we don't really want
Suggested change
| converted_meas = self.expect.convert(~StateFn(op) @ states_op) | |
| converted_meas = self.expect.convert(StateFn(op, is_measurement=True) @ states_op) |
There was a problem hiding this comment.
I agree with the commit and I changed the expected result from [0, 0, -1j, 1j] to [0, 0, 1j, -1j] to match this modification.
| op_mat = np.array([[0, 1], [2, 3]]) | ||
| op = MatrixOp(op_mat) | ||
|
|
||
| converted_meas = self.expect.convert(~StateFn(op) @ states_op) |
There was a problem hiding this comment.
Suggested change
| converted_meas = self.expect.convert(~StateFn(op) @ states_op) | |
| converted_meas = self.expect.convert(StateFn(op, is_measurement=True) @ states_op) |
Cryoris
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
QEOM creates a dictionary of operators to evaluate on the groundstate.
When using the noisy simulators (qasm_simulator or aer_simulator), one
could either use PauliExpectation (with noise) or AerPauliExpectation
(without noise). PauliExpectation works with non-hermitian operators
but internal methods of AerPauliExpectation raised an Error.
This is a workaround to this limitation.
Note that using include_custom=True on qasm allows the VQE to use a
local AerPauliExpectation without using the "expectation" input.
This does not apply to QEOM and one should explicitly define the
"expectation" input of the VQE for it to apply globally.