Fix plot_error_map with BackendProperties set or BackendV2 #7880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#7814 we updated the plot_error_map() error to be more general and also work with BackendV2 instead of assuming it's a BaseBackend or BackendV1 backend. However, as part of that refactor 2 errors were accidently introduced preventing the function from being used. First in the BackendV2 path we were incorrectly handling the backend name to use for the plot title. Secondly, in the BaseBackend/BackendV1 path the readout error array loop was incorrectly constructed resulting in the array being larger than expected causing an error. This commit fixes both conditions so that we can correctly plot the result. Fixes Qiskit#7879
mtreinish
requested review from
a team,
nonhermitian and
nkanazawa1989
as code owners
mtreinish
added
stable backport potential
jakelishman
reviewed
Apr 4, 2022
|
Heh, yeah the complete lack of test coverage for this function is how this slipped in the first place. I'll add some tests |
Pull Request Test Coverage Report for Build 2091796475
💛 - Coveralls |
This commit adds test coverage for plot_error_map. The reason the issues around this function slipped in was a complete lack of test coverage. This adds some basic tests with both the BackendV1 and BackendV2 test paths to ensure we have some coverage for the function.
jakelishman
reviewed
Apr 4, 2022
mtreinish
changed the title
jakelishman
approved these changes
Apr 4, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
* Fix plot_error_map In #7814 we updated the plot_error_map() error to be more general and also work with BackendV2 instead of assuming it's a BaseBackend or BackendV1 backend. However, as part of that refactor 2 errors were accidently introduced preventing the function from being used. First in the BackendV2 path we were incorrectly handling the backend name to use for the plot title. Secondly, in the BaseBackend/BackendV1 path the readout error array loop was incorrectly constructed resulting in the array being larger than expected causing an error. This commit fixes both conditions so that we can correctly plot the result. Fixes #7879 * Add tests for plot_error_map This commit adds test coverage for plot_error_map. The reason the issues around this function slipped in was a complete lack of test coverage. This adds some basic tests with both the BackendV1 and BackendV2 test paths to ensure we have some coverage for the function. * Add release note (cherry picked from commit d430e4d)
mergify bot
added a commit
that referenced
this pull request
Apr 4, 2022
…7887) * Fix plot_error_map In #7814 we updated the plot_error_map() error to be more general and also work with BackendV2 instead of assuming it's a BaseBackend or BackendV1 backend. However, as part of that refactor 2 errors were accidently introduced preventing the function from being used. First in the BackendV2 path we were incorrectly handling the backend name to use for the plot title. Secondly, in the BaseBackend/BackendV1 path the readout error array loop was incorrectly constructed resulting in the array being larger than expected causing an error. This commit fixes both conditions so that we can correctly plot the result. Fixes #7879 * Add tests for plot_error_map This commit adds test coverage for plot_error_map. The reason the issues around this function slipped in was a complete lack of test coverage. This adds some basic tests with both the BackendV1 and BackendV2 test paths to ensure we have some coverage for the function. * Add release note (cherry picked from commit d430e4d) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #7814 we updated the plot_error_map() error to be more general and
also work with BackendV2 instead of assuming it's a BaseBackend or
BackendV1 backend. However, as part of that refactor 2 errors were
accidently introduced preventing the function from being used. First in
the BackendV2 path we were incorrectly handling the backend name to use
for the plot title. Secondly, in the BaseBackend/BackendV1 path the
readout error array loop was incorrectly constructed resulting in the
array being larger than expected causing an error. This commit fixes
both conditions so that we can correctly plot the result.
Details and comments
Fixes #7879