Fix indent & improve consistency of primitive docs with Qiskit

[Cryoris]

Summary

There was an indent missing in the EstimatorBase:

And not all functions were fully documented (missing input args or return docs). Also I tried to improve the consistency with the rest of Qiskit whre we usually use full sentences in the docs, but feel free to reject or adjust that!

Details and comments

Is there a reason why we use collections.abc for typehints instead of typing as in the most of the (or all?) codebase? 🙂

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core
• @ajavadia
• @ikkoham
• @levbishop
• @t-imamichi

[coveralls]

Pull Request Test Coverage Report for Build 2106039826

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 3 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.005%) to 83.927%

---

Files with Coverage Reduction	New Missed Lines	%
qiskit/pulse/library/waveform.py	3	89.36%

Totals
Change from base Build 2103378125:	-0.005%
Covered Lines:	54136
Relevant Lines:	64504

---

💛 - Coveralls

[ikkoham]

Thank you so much and sorry for my mistakes. This is the right direction.
I just have one question, should we use Sphinx's :class:ClassName etc. in the doc string? For html it is obviously readable, but I am concerned that it may be difficult to read when viewed with the help function (or completion). I know that this is used in QuantumCircuit and others, but I would like to check it once.

Is there a reason why we use collections.abc for typehints instead of typing as in the most of the (or all?) codebase?

typing.Sequence is deprecated since Python 3.9, so if we use __future__.annotations , I believe that collections.abc is better.

[Cryoris]

just have one question, should we use Sphinx's :class:ClassName etc. in the doc string?

I don't think it's strictly necessary since most of the classes could be accessed via the type-documentation. But also I don't think there's harm in being precise and these paths are not very long. We can do which ever you prefer 🙂

[ikkoham]

@Cryoris Thank you. I agree that it is not very long. LGTM.