Fix dag visualization for DAGCircuits without registers #7923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the handling of generating visualizations for DAGCircuit objects that have standalone bit objects. Previously, the dag_drawer() function was assuming every bit in the dag was a member of a register. In the case of circuits with standalone bits this is not the case and would result in a KeyError being raised when the register was attempted to be used to generate a string label for the node or edge in the visualization. This fixes this by still using registers if present, but in the absence of a register it fallsback to using it's absolute index in the dag to generate a similar label. For example, the 4th qubit will have the label "q[4]" in the output visualization. Fixes Qiskit#7915
mtreinish
added
stable backport potential
mtreinish
requested review from
a team,
nonhermitian and
nkanazawa1989
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2167657410
💛 - Coveralls |
jakelishman
reviewed
Apr 12, 2022
This commit changes the default fallback label when no register match is found to be of the form q_0, where 0 is the qubit index. This was done to avoid potential confusion with a register named q which might be in the circuit and not the first element in the qubits list.
jakelishman
approved these changes
Apr 14, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Fix dag visualization for DAGCircuits without registers This commit fixes the handling of generating visualizations for DAGCircuit objects that have standalone bit objects. Previously, the dag_drawer() function was assuming every bit in the dag was a member of a register. In the case of circuits with standalone bits this is not the case and would result in a KeyError being raised when the register was attempted to be used to generate a string label for the node or edge in the visualization. This fixes this by still using registers if present, but in the absence of a register it fallsback to using it's absolute index in the dag to generate a similar label. For example, the 4th qubit will have the label "q[4]" in the output visualization. Fixes #7915 * Adjust default label from q[0] to q_0 This commit changes the default fallback label when no register match is found to be of the form q_0, where 0 is the qubit index. This was done to avoid potential confusion with a register named q which might be in the circuit and not the first element in the qubits list. * Add release note * Add test Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 4463ac3)
mergify bot
added a commit
that referenced
this pull request
Apr 14, 2022
* Fix dag visualization for DAGCircuits without registers This commit fixes the handling of generating visualizations for DAGCircuit objects that have standalone bit objects. Previously, the dag_drawer() function was assuming every bit in the dag was a member of a register. In the case of circuits with standalone bits this is not the case and would result in a KeyError being raised when the register was attempted to be used to generate a string label for the node or edge in the visualization. This fixes this by still using registers if present, but in the absence of a register it fallsback to using it's absolute index in the dag to generate a similar label. For example, the 4th qubit will have the label "q[4]" in the output visualization. Fixes #7915 * Adjust default label from q[0] to q_0 This commit changes the default fallback label when no register match is found to be of the form q_0, where 0 is the qubit index. This was done to avoid potential confusion with a register named q which might be in the circuit and not the first element in the qubits list. * Add release note * Add test Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 4463ac3) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes the handling of generating visualizations for
DAGCircuit objects that have standalone bit objects. Previously, the
dag_drawer() function was assuming every bit in the dag was a member of
a register. In the case of circuits with standalone bits this is not the
case and would result in a KeyError being raised when the register was
attempted to be used to generate a string label for the node or edge
in the visualization. This fixes this by still using registers if
present, but in the absence of a register it falls back to using it's
absolute index in the dag to generate a similar label. For example, the
4th qubit will have the label "q[4]" in the output visualization.
Details and comments
Fixes #7915