Fix order of input and gate declarations in QASM 3 exporter #7972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current reference grammar requires that inputs and outputs are defined before any gate declarations, so previously exported OpenQASM 3 programmes could fail to parse with the reference implementation. It is likely that the ordering is an arbitrary restriction and can be removed from the grammar, but for the time being, we ought to match what is written.
jakelishman
added
stable backport potential
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2216188543
💛 - Coveralls |
taalexander
approved these changes
Apr 24, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2022
The current reference grammar requires that inputs and outputs are defined before any gate declarations, so previously exported OpenQASM 3 programmes could fail to parse with the reference implementation. It is likely that the ordering is an arbitrary restriction and can be removed from the grammar, but for the time being, we ought to match what is written. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 446af33)
mergify bot
added a commit
that referenced
this pull request
Apr 25, 2022
…7984) The current reference grammar requires that inputs and outputs are defined before any gate declarations, so previously exported OpenQASM 3 programmes could fail to parse with the reference implementation. It is likely that the ordering is an arbitrary restriction and can be removed from the grammar, but for the time being, we ought to match what is written. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 446af33) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
jakelishman
added
mod: qasm3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current reference grammar requires that inputs and outputs are
defined before any gate declarations, so previously exported OpenQASM 3
programmes could fail to parse with the reference implementation. It is
likely that the ordering is an arbitrary restriction and can be removed
from the grammar, but for the time being, we ought to match what is
written.
Details and comments
Fix #7964.