Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSPLayout is being deprecated in favour of VF2Layout #8037

Closed
wants to merge 2 commits into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented May 10, 2022

In #4443 we replaced CSPLayout with VF2Layout. Since the are functionally equivalent, I suggest to remove CSPLayout.

@1ucian0 1ucian0 requested a review from a team as a code owner May 10, 2022 16:51
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2306723228

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.377%

Totals Coverage Status
Change from base Build 2291551136: 0.01%
Covered Lines: 54499
Relevant Lines: 64590

💛 - Coveralls

@1ucian0 1ucian0 added this to the 0.21 milestone May 15, 2022
@1ucian0
Copy link
Member Author

1ucian0 commented May 18, 2022

After some off-band discussions, we decided to keep CSP in terra.

@1ucian0 1ucian0 closed this May 18, 2022
@1ucian0 1ucian0 changed the title CSPLayout is being deprecated in favor of VF2Layout CSPLayout is being deprecated in favour of VF2Layout May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants