Rename (Minimum)EigensolverResult.aux_operator_eigenvalues from "eigenvalues" to just "values"
#8053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
mtreinish
reviewed
May 11, 2022
Pull Request Test Coverage Report for Build 2308497351
💛 - Coveralls |
woodsp-ibm
reviewed
May 11, 2022
woodsp-ibm
reviewed
May 11, 2022
woodsp-ibm
reviewed
May 11, 2022
qiskit/algorithms/minimum_eigen_solvers/minimum_eigen_solver.py
Outdated
Show resolved
Hide resolved
woodsp-ibm
reviewed
May 11, 2022
qiskit/algorithms/minimum_eigen_solvers/minimum_eigen_solver.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
|
This has been addressed by #8702 where the result has been renamed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The eigensolver algorithms allow the evaluation of the expectation value of auxiliary operators at the final optimal point. These expectation values are generally not the eigenvalue of the auxiliary operators. However we currently store these expectations in an attribute called
aux_operator_eigenvalueswhich is a bit misleading. This commit renames the attribute to justaux_operator_valuesto reflect that it's not an eigenvalue.