Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks if DiagonalGate has modulus 1 #8098

Merged
merged 4 commits into from
May 23, 2022
Merged

Checks if DiagonalGate has modulus 1 #8098

merged 4 commits into from
May 23, 2022

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented May 21, 2022

Fixes #3842

I took the suggested solution from #3842 (thanks @hhyap!) and the test from #4375 (thanks @ewinston!)

This issue was simple enough if you do not consider the full extend of #4375

@1ucian0 1ucian0 requested a review from a team as a code owner May 21, 2022 21:11
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

Co-authored-by: ewinston <ewinston@users.noreply.github.com>
Co-authored-by: hhyap <hhyap@users.noreply.github.com>
@coveralls
Copy link

coveralls commented May 21, 2022

Pull Request Test Coverage Report for Build 2370777544

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 84.376%

Totals Coverage Status
Change from base Build 2370437301: 0.002%
Covered Lines: 54539
Relevant Lines: 64638

💛 - Coveralls

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jakelishman jakelishman added Changelog: Bugfix Include in the "Fixed" section of the changelog automerge labels May 23, 2022
@jakelishman jakelishman added this to the 0.21 milestone May 23, 2022
@mergify mergify bot merged commit d2e3340 into Qiskit:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiagonalGate does not raise when diagonal entries do not have modulus 1
4 participants