Add function to easily generate preset pass managers #8125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new function, generate_preset_pass_managers(), which is used to quickly generate the preset pass manager for manual interaction. Prior to this new function there were lower level functions which are used to generate the individual pass manager objects for each optimization level but they are hidden behind an abstraction object, PassManagerConfig which is the only input. This makes it harder to work with because the user has to manually remember to generate the config object prior to creating the pass manager. Similarly this new function simplifies the creation of preset pass managers by having a single entry point instead of 4 for each optimization level.
mtreinish
added
the
Changelog: New Feature
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2429289079
💛 - Coveralls |
Cryoris
reviewed
Jun 2, 2022
If a user manually specifies a Target object to use as the compilation target we still need to generate the old data structures to trigger some passes to run. We also want the properties of the target to supersede those in a specified backend if it's manually specified. This commit corrects the handling of this so the manually specified target is the source of truth when specified.
Cryoris
reviewed
Jun 2, 2022
releasenotes/notes/generate_pass_manager_preset-1e6c9641accd5d60.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Cryoris
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a new function,
generate_preset_pass_managers(), whichis used to quickly generate the preset pass manager for manual
interaction. Prior to this new function there were lower level functions
which are used to generate the individual pass manager objects for each
optimization level but they are hidden behind an abstraction object,
PassManagerConfigwhich is the only input. This makes it harder to workwith because the user has to manually remember to generate the config
object prior to creating the pass manager. Similarly this new function
simplifies the creation of preset pass managers by having a single entry
point instead of 4 for each optimization level.
Details and comments