-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Result to always contain date, status, header #8216
Conversation
Update 11/30/20
Date attribute is needed for some specific applications such as mitigation in mthree. It is not created by default when running a job in the basicAer backend.
I have no clue why in the test_results the attribute status is repeated.
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Added to the 0.21 milestone after the feature-freeze deadline because this PR is just a continuation of #7877, needed because the original contributor isn't available before the deadline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the fast updates!
Pull Request Test Coverage Report for Build 2537616046
💛 - Coveralls |
Summary
Fixes #7781
Closes #7877
Details and comments
Addresses final comments in #7781.