Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Result to always contain date, status, header #8216

Merged
merged 11 commits into from
Jun 21, 2022

Conversation

kevinsung
Copy link
Contributor

Summary

Fixes #7781
Closes #7877

Details and comments

Addresses final comments in #7781.

alejomonbar and others added 8 commits November 30, 2020 15:42
Date attribute is needed for some specific applications such as mitigation in mthree. It is not created by default when running a job in the basicAer backend.
I have no clue why in the test_results the attribute status is repeated.
@kevinsung kevinsung requested a review from a team as a code owner June 21, 2022 16:36
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@jakelishman jakelishman added this to the 0.21 milestone Jun 21, 2022
@jakelishman
Copy link
Member

Added to the 0.21 milestone after the feature-freeze deadline because this PR is just a continuation of #7877, needed because the original contributor isn't available before the deadline.

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the fast updates!

@jakelishman jakelishman added Changelog: API Change Include in the "Changed" section of the changelog Changelog: Bugfix Include in the "Fixed" section of the changelog automerge labels Jun 21, 2022
@coveralls
Copy link

coveralls commented Jun 21, 2022

Pull Request Test Coverage Report for Build 2537616046

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 84.279%

Totals Coverage Status
Change from base Build 2537614103: 0.001%
Covered Lines: 54880
Relevant Lines: 65117

💛 - Coveralls

@mergify mergify bot merged commit 992c261 into Qiskit:main Jun 21, 2022
@kevinsung kevinsung deleted the Issue7781 branch June 21, 2022 20:55
@HuangJunye HuangJunye added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: API Change Include in the "Changed" section of the changelog Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add date attribute to BasicAer job result
6 participants