Fix mypy errors (quantum_info) #8257

Randl · 2022-06-28T14:07:39Z

Summary

Following discussion, I'm splitting #8187 by module.

Details and comments

There are 8 errors left:

qiskit/quantum_info/synthesis/two_qubit_decompose.py:580: error: Missing positional arguments "num_qubits", "params" in call to "Gate"  [call-arg]
qiskit/quantum_info/synthesis/two_qubit_decompose.py:580: error: Argument 1 to "Gate" has incompatible type "float"; expected "str"  [arg-type]
qiskit/quantum_info/synthesis/two_qubit_decompose.py:583: error: Missing positional arguments "num_qubits", "params" in call to "Gate"  [call-arg]
qiskit/quantum_info/synthesis/two_qubit_decompose.py:583: error: Argument 1 to "Gate" has incompatible type "float"; expected "str"  [arg-type]
qiskit/quantum_info/synthesis/two_qubit_decompose.py:590: error: Missing positional arguments "num_qubits", "params" in call to "Gate"  [call-arg]
qiskit/quantum_info/synthesis/two_qubit_decompose.py:590: error: Argument 1 to "Gate" has incompatible type "float"; expected "str"  [arg-type]
qiskit/quantum_info/synthesis/two_qubit_decompose.py:665: error: Missing positional arguments "num_qubits", "params" in call to "Gate"  [call-arg]
qiskit/quantum_info/synthesis/two_qubit_decompose.py:665: error: Argument 1 to "Gate" has incompatible type "float"; expected "str"  [arg-type]

All are related to the fact that gates, even though inheriting from Gate have different constructor signature. Not sure what the proper fix is.
The ignores are related to python/mypy#1362

qiskit-bot · 2022-06-28T14:07:44Z

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@Qiskit/terra-core
@ikkoham

kevinsung · 2023-02-06T14:36:32Z

The ignores are related to python/mypy#1362

That issue is closed. Do you still get an error if you run with the latest version of mypy?

qiskit/quantum_info/states/statevector.py

coveralls · 2023-02-07T07:30:39Z

Pull Request Test Coverage Report for Build 4117876587

5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.002%) to 85.277%

Files with Coverage Reduction	New Missed Lines	%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py	2	93.97%
qiskit/pulse/library/waveform.py	3	91.67%

Totals
Change from base Build 4114140947:	-0.002%
Covered Lines:	67251
Relevant Lines:	78862

💛 - Coveralls

Randl · 2023-02-07T08:36:35Z

The code related to this issue is removed anyway. I've rebased on current master and updated correspondingly

kevinsung

Thanks! Are there any more mypy issues in this module? If so, could you report the output?

Randl · 2023-02-07T15:01:41Z

There are a few left:

out.txt:qiskit/quantum_info/synthesis/two_qubit_decompose.py:585: error: Missing positional arguments "num_qubits", "params" in call to "Gate"  [call-arg]
out.txt:qiskit/quantum_info/synthesis/two_qubit_decompose.py:588: error: Missing positional arguments "num_qubits", "params" in call to "Gate"  [call-arg]
out.txt:qiskit/quantum_info/synthesis/two_qubit_decompose.py:595: error: Missing positional arguments "num_qubits", "params" in call to "Gate"  [call-arg]
out.txt:qiskit/quantum_info/synthesis/two_qubit_decompose.py:670: error: Missing positional arguments "num_qubits", "params" in call to "Gate"  [call-arg]
out.txt:qiskit/quantum_info/synthesis/two_qubit_decompose.py:670: error: Argument 1 to "Gate" has incompatible type "float"; expected "str"  [arg-type]
out.txt:qiskit/quantum_info/synthesis/xx_decompose/decomposer.py:99: error: Item "QuantumCircuit" of "Union[List[Any], QuantumCircuit]" has no attribute "__iter__" (not iterable)  [union-attr]

All except one are since Gate overloads have different constructor parameters. The last one I'm unsure about.

kevinsung · 2023-02-07T16:11:13Z

The last one seems like it's related to one of your changes, right? Could you please post the mypy outputs both before and after the changes you made?

Randl · 2023-02-07T16:24:27Z

Ok, this is a consequence of the fact that QuantumCircuit implements getitem but not iter: python/mypy#9737

Not sure what is the appropriate fix? Maybe just adding iter function

kevinsung · 2023-02-07T16:33:19Z

qiskit/quantum_info/synthesis/xx_decompose/decomposer.py

@@ -93,7 +93,9 @@ def __init__(
        self.basis_fidelity = basis_fidelity

        # expose one of the basis gates so others can know what this decomposer targets
-        embodiment_circuit = next(iter(self.embodiments.items()), ([], []))[1]
+        embodiment_circuit: list | QuantumCircuit = next(iter(self.embodiments.items()), ([], []))[


Shouldn't it be CircuitInstruction instead of QuantumCircuit?

I don't think so. This docstring mentions "circuit"
https://github.com/Qiskit/qiskit-terra/blob/089017cda48fadb7b4d8e7f11a9c5d5074ec5751/qiskit/quantum_info/synthesis/xx_decompose/decomposer.py#L66-L68
and tests use "circuit"
https://github.com/Qiskit/qiskit-terra/blob/089017cda48fadb7b4d8e7f11a9c5d5074ec5751/test/python/quantum_info/xx_decompose/test_decomposer.py#L82-L97
maybe the code should accept both tho.

Looking at the code, it seems that

next(iter(self.embodiments.items()), ([], []))

should be a QuantumCircuit. But then embodiment_circuit is actually obtained by indexing into this object:

next(iter(self.embodiments.items()), ([], []))[1]

self.embodiments is a dictionary, so self.embodiments.items() contains tuples, and thus indexing will return the second element of first tuple, i.e., circuit

Ah, ok. It seems this line can be significantly simplified by calling self.embodiments.values() instead of items. You can go ahead and make that change if you like, but it's not necessary.

kevinsung

Thanks! If you decide to update your other mypy PRs, please include the mypy output both before and after your changes. That would make the review easier.

Randl · 2023-02-08T08:09:14Z

@kevinsung Thanks! I've added the mypy output after changes, but keeping PRs up-to-date is a bit annoying, so I'm waiting for some of the maintainers to engage on specific PR before updating it. Feel free to ping me if you want me to update some specific ones.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Randl requested review from a team and ikkoham as code owners June 28, 2022 14:07

javabster added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jun 28, 2022

javabster assigned kevinsung Feb 6, 2023

kevinsung reviewed Feb 6, 2023

View reviewed changes

qiskit/quantum_info/states/statevector.py Outdated Show resolved Hide resolved

Randl force-pushed the mypy-6 branch from 3845d77 to fd7831f Compare February 6, 2023 18:24

Randl requested review from alexanderivrii and ShellyGarion as code owners February 6, 2023 18:24

Fix quantum_info mypy errors

089017c

Randl force-pushed the mypy-6 branch from fd7831f to 089017c Compare February 7, 2023 07:04

kevinsung reviewed Feb 7, 2023

View reviewed changes

kevinsung approved these changes Feb 7, 2023

View reviewed changes

kdk approved these changes Feb 7, 2023

View reviewed changes

kdk added automerge Changelog: None Do not include in changelog labels Feb 7, 2023

kdk added this to the 0.24.0 milestone Feb 7, 2023

Merge branch 'main' into mypy-6

8b503f9

mergify bot merged commit 202ec09 into Qiskit:main Feb 7, 2023

pranay1990 pushed a commit to pranay1990/qiskit-terra that referenced this pull request Feb 9, 2023

Fix quantum_info mypy errors (Qiskit#8257)

90268a3

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix mypy errors (quantum_info) #8257

Fix mypy errors (quantum_info) #8257

Randl commented Jun 28, 2022

qiskit-bot commented Jun 28, 2022

kevinsung commented Feb 6, 2023

coveralls commented Feb 7, 2023 •

edited

Loading

Randl commented Feb 7, 2023

kevinsung left a comment

Randl commented Feb 7, 2023

kevinsung commented Feb 7, 2023

Randl commented Feb 7, 2023 •

edited

Loading

kevinsung Feb 7, 2023

Randl Feb 7, 2023 •

edited

Loading

kevinsung Feb 7, 2023

Randl Feb 7, 2023

kevinsung Feb 7, 2023

kevinsung left a comment

Randl commented Feb 8, 2023

Fix mypy errors (quantum_info) #8257

Fix mypy errors (quantum_info) #8257

Conversation

Randl commented Jun 28, 2022

Summary

Details and comments

qiskit-bot commented Jun 28, 2022

kevinsung commented Feb 6, 2023

coveralls commented Feb 7, 2023 • edited Loading

Pull Request Test Coverage Report for Build 4117876587

💛 - Coveralls

Randl commented Feb 7, 2023

kevinsung left a comment

Choose a reason for hiding this comment

Randl commented Feb 7, 2023

kevinsung commented Feb 7, 2023

Randl commented Feb 7, 2023 • edited Loading

kevinsung Feb 7, 2023

Choose a reason for hiding this comment

Randl Feb 7, 2023 • edited Loading

Choose a reason for hiding this comment

kevinsung Feb 7, 2023

Choose a reason for hiding this comment

Randl Feb 7, 2023

Choose a reason for hiding this comment

kevinsung Feb 7, 2023

Choose a reason for hiding this comment

kevinsung left a comment

Choose a reason for hiding this comment

Randl commented Feb 8, 2023

coveralls commented Feb 7, 2023 •

edited

Loading

Randl commented Feb 7, 2023 •

edited

Loading

Randl Feb 7, 2023 •

edited

Loading