Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add atol parameter to SparsePauliOp.equiv #8281

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

kevinsung
Copy link
Contributor

Summary

Adds atol parameter to SparsePauliOp.equiv.

Details and comments

@kevinsung kevinsung requested review from a team and ikkoham as code owners June 30, 2022 16:03
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Jun 30, 2022

Pull Request Test Coverage Report for Build 2617177950

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0005%) to 84.004%

Totals Coverage Status
Change from base Build 2611640146: 0.0005%
Covered Lines: 55825
Relevant Lines: 66455

💛 - Coveralls

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 this also doesn't change the default behavior since NumPy's default for atol is 1e-8 which is the same as the tolerances mixin now provides as default.

I'll hold off automerge to give others a chance to review, maybe @chriseclectic or @ikkoham have an opinion here!

Copy link
Member

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@Cryoris Cryoris added Changelog: New Feature Include in the "Added" section of the changelog automerge labels Jul 5, 2022
@mergify mergify bot merged commit c60d3b8 into Qiskit:main Jul 5, 2022
@kevinsung kevinsung deleted the sparse-pauli-equiv-atol branch July 5, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants