Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imaginary part displayed on plot_hinton in Visualization #8311

Closed
wants to merge 1 commit into from

Conversation

dimple12M
Copy link

@dimple12M dimple12M commented Jul 8, 2022

Fixes #8324

Issue in the Imaginary section of the plot_hinton. matrix elements displayed not properly and the square size in the imaginary part were not equal.
In the image below, the imaginary part of the plot_hinton has 2 issues:

  1. imaginary matrix elements not displayed properly
  2. squares in the img are not equal.
    Screenshot 2022-07-07 at 5 12 59 PM

In the Image below, done few changes in the state_visualization.py and the following correct plot is observed.
Screenshot 2022-07-08 at 5 58 12 PM

Issue in the Imaginary section of the plot_hinton. matrix elements displayed not properly and the square size in the imaginary part were not equal.
@dimple12M dimple12M requested review from a team, nonhermitian and nkanazawa1989 as code owners July 8, 2022 10:47
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HuangJunye HuangJunye added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jul 8, 2022
@1ucian0
Copy link
Member

1ucian0 commented Jul 10, 2022

Hi @dimple12M, this PR looks... a bit... unorthodox :)

DEV recently released a very nice article and short article that explains how to do open-source contributions. Have a look, specifically to the Pull Requests section. You can also ask for help in the #qiskit-pr-help channel in Slack.

@1ucian0 1ucian0 closed this Jul 10, 2022
@dimple12M
Copy link
Author

Hi ,
With respect to this query https://qiskit.slack.com/archives/CB6C24TPB/p1657185479453929 I made few changes in the state_visualization.py file . This is my first PR related to the Qiskit source code contribution. I understand there are some guidelines to follow. But I am unable to get it about whether this issue is valid and can I do the PR again ?
Kindly, request to get some info related to this.

@dimple12M dimple12M changed the title Add files via upload Issue with the imaginary part displayed on plot_hinton in Visualization Jul 10, 2022
@dimple12M dimple12M changed the title Issue with the imaginary part displayed on plot_hinton in Visualization Imaginary part displayed on plot_hinton in Visualization Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Plot_hinton imaginary section displays incorrect elements
5 participants