Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPL and LaTeX circuit drawer when idle_wires=False and there are barriers #8321

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

enavarro51
Copy link
Contributor

Summary

Fixes #8313

Details and comments

This PR fixes a problem where setting the idle_wires option to False in the 'mpl' or 'latex' circuit drawers when there was a barrier in the circuit would cause the drawer to fail.

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Jul 11, 2022

Pull Request Test Coverage Report for Build 2755519949

  • 3 of 10 (30.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 83.991%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/matplotlib.py 0 7 0.0%
Totals Coverage Status
Change from base Build 2755253223: -0.003%
Covered Lines: 55896
Relevant Lines: 66550

💛 - Coveralls

@1ucian0 1ucian0 added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jul 12, 2022
@1ucian0 1ucian0 self-assigned this Jul 12, 2022
@1ucian0 1ucian0 changed the title Fix idle wires False with barrier Fix MPL drawer when idle_wires=False and there are barriers Jul 27, 2022
@1ucian0 1ucian0 added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jul 27, 2022
@1ucian0 1ucian0 changed the title Fix MPL drawer when idle_wires=False and there are barriers Fix MPL and LaTeX circuit drawer when idle_wires=False and there are barriers Jul 27, 2022
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@1ucian0 1ucian0 merged commit 244fd84 into Qiskit:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

mpl circ drawer fails with idle_wires=False
4 participants