Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensored fitter #8345

Merged
merged 15 commits into from
Jul 15, 2022
Merged

Tensored fitter #8345

merged 15 commits into from
Jul 15, 2022

Conversation

eggerdj
Copy link
Contributor

@eggerdj eggerdj commented Jul 14, 2022

Summary

We cannot run readout error mitigation at scale in Qiskit Terra for permuted qubits since the only fitter that works is the CompletMeasFitter which does not scale. This PR makes it possible to use the TensoredMeasFitter in an algorithm in which the qubit order might be different from 0, 1, 2, ....

Details and comments

This PR provides only a partial implementation of the method subset_fitter. However, it implements the most useful case making it possible to implement readout error mitigation at scale in Qiskit Terra. It supports fitters in which the mitigation pattern is of the form [[idx] for idx in range(num_qubits)].

@eggerdj eggerdj requested review from a team, manoelmarques and woodsp-ibm as code owners July 14, 2022 14:26
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Jul 14, 2022

Pull Request Test Coverage Report for Build 2677768248

  • 17 of 19 (89.47%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 84.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/utils/mitigation/fitters.py 15 17 88.24%
Files with Coverage Reduction New Missed Lines %
qiskit/utils/quantum_instance.py 3 71.77%
Totals Coverage Status
Change from base Build 2676906129: -0.003%
Covered Lines: 55893
Relevant Lines: 66539

💛 - Coveralls

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments below, but LGTM 👍🏻 Maybe someone else with a bit more knowledge of this code should have another look though 😄

test/python/algorithms/test_measure_error_mitigation.py Outdated Show resolved Hide resolved
qiskit/utils/quantum_instance.py Outdated Show resolved Hide resolved
manoelmarques
manoelmarques previously approved these changes Jul 15, 2022
@woodsp-ibm
Copy link
Member

Can we add a reno release note for this new feature

@manoelmarques manoelmarques self-requested a review July 15, 2022 15:29
@woodsp-ibm woodsp-ibm added the Changelog: New Feature Include in the "Added" section of the changelog label Jul 15, 2022
@woodsp-ibm woodsp-ibm added this to the 0.22 milestone Jul 15, 2022
@eggerdj eggerdj merged commit 40668f0 into Qiskit:main Jul 15, 2022
@eggerdj eggerdj deleted the tensored_fitter branch July 15, 2022 19:22
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
* This PR adds a method subset_fitter to the TensoredMeasFitter in Terra. The 
subset_fitter provides a new fitter by reordering the calibration matrices in the internal 
list of the fitter.
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
* This PR adds a method subset_fitter to the TensoredMeasFitter in Terra. The 
subset_fitter provides a new fitter by reordering the calibration matrices in the internal 
list of the fitter.
ElePT pushed a commit to ElePT/qiskit-algorithms that referenced this pull request Jul 27, 2023
* This PR adds a method subset_fitter to the TensoredMeasFitter in Terra. The 
subset_fitter provides a new fitter by reordering the calibration matrices in the internal 
list of the fitter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants