-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensored fitter #8345
Tensored fitter #8345
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2677768248
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments below, but LGTM 👍🏻 Maybe someone else with a bit more knowledge of this code should have another look though 😄
Can we add a reno release note for this new feature |
* This PR adds a method subset_fitter to the TensoredMeasFitter in Terra. The subset_fitter provides a new fitter by reordering the calibration matrices in the internal list of the fitter.
* This PR adds a method subset_fitter to the TensoredMeasFitter in Terra. The subset_fitter provides a new fitter by reordering the calibration matrices in the internal list of the fitter.
* This PR adds a method subset_fitter to the TensoredMeasFitter in Terra. The subset_fitter provides a new fitter by reordering the calibration matrices in the internal list of the fitter.
Summary
We cannot run readout error mitigation at scale in Qiskit Terra for permuted qubits since the only fitter that works is the
CompletMeasFitter
which does not scale. This PR makes it possible to use theTensoredMeasFitter
in an algorithm in which the qubit order might be different from 0, 1, 2, ....Details and comments
This PR provides only a partial implementation of the method
subset_fitter
. However, it implements the most useful case making it possible to implement readout error mitigation at scale in Qiskit Terra. It supports fitters in which the mitigation pattern is of the form[[idx] for idx in range(num_qubits)]
.