Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional backend in Job #8406

Closed
wants to merge 2 commits into from

Conversation

ikkoham
Copy link
Contributor

@ikkoham ikkoham commented Jul 27, 2022

Summary

It is proposed that backend be set to None in the Job to use the Job that is not related to backend.
#8382 (comment)

Can we extend the job like this PR?
Or, should we design the specific job class?

Details and comments

@ikkoham ikkoham requested review from a team and jyu00 as code owners July 27, 2022 16:44
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jul 27, 2022

Pull Request Test Coverage Report for Build 2754150868

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 83.991%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/providers/job.py 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
qiskit/providers/job.py 1 57.14%
Totals Coverage Status
Change from base Build 2748430390: -0.002%
Covered Lines: 55898
Relevant Lines: 66552

💛 - Coveralls

@ikkoham
Copy link
Contributor Author

ikkoham commented Aug 11, 2022

Closable since #8382 is merged.

@ikkoham ikkoham closed this Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants